New issue
Advanced search Search tips

Issue 922302 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

tast: support non-gs files for "External data files"

Project Member Reported by xiaochu@chromium.org, Jan 16

Issue description

I'm working on a remote test that needs to copy test data generated by a ebuild (located at /build/kefka/build/rootfs/dlc/demo-dlc/dlc.img) to DUT. Based on https://chromium.googlesource.com/chromiumos/platform/tast/+/HEAD/docs/writing_tests.md#external-data-files, the way to include test data that is not part of the tast-test repo is via uploading them to gs bucket which in my case not necessary - the test is expected to at least run on a dev machine.

The exact execution flow on a buildbot:
1. DLC image is built (stored temporarily) and metadata for verification is installed to rootfs.
2. dlc-tast-test copies the DLC image to DUT, starts a mock omaha server (python), then emulates a DLC installation process.
 
Cc: nya@chromium.org hidehiko@chromium.org
Can you explain more about the intended use of these tests? Tast tests generally run in an automated fashion. If the test is just intended for personal use within a chroot (e.g. to manually verify your changes), it probably shouldn't be checked in.

Comment 2 by nya@chromium.org, Jan 16 (6 days ago)

External data files download is initiated by the DUT, so we can't access files on CrOS SDK chroot.

Another way to provide a data file outside from tast-tests package is to install the files to test images. For example, chromeos-base/security-tests package installs several tiny binaries needed by tests. Is it possible for your case?

Comment 3 by xiaochu@chromium.org, Jan 16 (6 days ago)

Description: Show this description

Comment 4 by xiaochu@chromium.org, Jan 16 (6 days ago)

Status: WontFix (was: Untriaged)
Thanks for the feedback!

I edited the description a bit. I think nya@'s suggestion suits my use case well. We can have a chromeos-base/demo-dlc-tests that installs the DLC image to specific location on DUT. Then a local test is enough.

Comment 5 by derat@chromium.org, Jan 17 (6 days ago)

Great!

Just to check, how large is the DLC image that you're planning to install? Making it as small as possible is important, since free space on the stateful partition is a finite resource.

Comment 6 by xiaochu@chromium.org, Jan 17 (6 days ago)

Currently a few KBs. 

I'll definitely try to make it as small as possible to save downloading/installing time as well since it will run on cq.

Comment 7 by derat@chromium.org, Jan 17 (6 days ago)

Perfect, thanks!

Sign in to add a comment