Issue metadata
Sign in to add a comment
|
Flaky ASSERT on angle_end2end_tests on Win10 FYI Debug (NVIDIA) |
||||||||||||||||||||||
Issue descriptionhttps://chromium-swarm.appspot.com/task?id=426c6eecb6631f10&refresh=10&show_raw=1 fails with the following in the logs: [ RUN ] CubeMapTextureTest.RenderToFacesConsecutively/ES2_D3D11_10_0 Assertion failed: mState.surfaceSet.empty(), file ../../third_party/angle/src/libANGLE/renderer/DisplayImpl.cpp, line 23 Likewise https://chromium-swarm.appspot.com/task?id=426b90d66165d510&refresh=10&show_raw=1 fails with [ RUN ] Texture2DArrayCopy.UintFormats/ES3_D3D11 Assertion failed: mState.surfaceSet.empty(), file ../../third_party/angle/src/libANGLE/renderer/DisplayImpl.cpp, line 23 The regression range contains https://chromium-review.googlesource.com/c/angle/angle/+/1409868 which seems related. Reverting for now, and assigning to geofflang.
,
Jan 16
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/410cee815062198e8b20d8c2776b1ec9e3fbffb2 commit 410cee815062198e8b20d8c2776b1ec9e3fbffb2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Jan 16 06:26:36 2019 Roll src/third_party/angle d3e0e84ce7e1..ab2bfa814cee (5 commits) https://chromium.googlesource.com/angle/angle.git/+log/d3e0e84ce7e1..ab2bfa814cee git log d3e0e84ce7e1..ab2bfa814cee --date=short --no-merges --format='%ad %ae %s' 2019-01-16 jmadill@chromium.org Enable Chromium clang style plugin for libANGLE. 2019-01-16 cwallez@chromium.org Revert "Don't call Texture::onDestroy twice for the zero textures." 2019-01-16 jmadill@chromium.org Make BUILD.gn targets into templates. 2019-01-15 timvp@google.com Fix show_angle_in_use_dialog_box Global.Setting Name 2019-01-15 syoussefi@chromium.com Fix block size calculation w.r.t variable-size arrays Created with: gclient setdep -r src/third_party/angle@ab2bfa814cee The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:922296 TBR=cwallez@chromium.org Change-Id: I0db72a7b37ff568453442a064238d51bf25afae9 Reviewed-on: https://chromium-review.googlesource.com/c/1414371 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623134} [modify] https://crrev.com/410cee815062198e8b20d8c2776b1ec9e3fbffb2/DEPS
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/d46165e3db5ab44759a833ca53d142795cbe1fa1 commit d46165e3db5ab44759a833ca53d142795cbe1fa1 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Jan 17 17:14:20 2019 Reland "Don't call Texture::onDestroy twice for the zero textures." This reverts commit 3adcf1e4cb5ce3cc1cc8a3dfed4ec44dff45f5ae. Reason for revert: Likely not the cause of failures seen. Original change's description: > Revert "Don't call Texture::onDestroy twice for the zero textures." > > This reverts commit d3e0e84ce7e1fcde7bbe71ebfba009ddd5942de3. > > Reason for revert: likely cause for crbug.com/922296 > > BUG= chromium:922296 > > Original change's description: > > Don't call Texture::onDestroy twice for the zero textures. > > > > The BindingPointer will call onDestroy when all references are removed, no > > need to do it explicitly. > > > > BUG=angleproject:3070 > > > > Change-Id: Ic5dd4da8f73e204d26d9d3a3c6e1eff9fded5411 > > Reviewed-on: https://chromium-review.googlesource.com/c/1409868 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Geoff Lang <geofflang@chromium.org> > > TBR=geofflang@chromium.org,jmadill@chromium.org > > Change-Id: I38097218d49940e7ac3ad914714294b019c154fd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: angleproject:3070 > Reviewed-on: https://chromium-review.googlesource.com/c/1413239 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:922296 , angleproject:3070 Change-Id: I58b1c445f81e4a7f38df375fd3311043b571e834 Reviewed-on: https://chromium-review.googlesource.com/c/1417770 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/d46165e3db5ab44759a833ca53d142795cbe1fa1/src/libANGLE/Context.cpp
,
Jan 17
(5 days ago)
I reverted a test enablement here: https://crrev.com/c/1417771 I think that should fix the flaky failures. We can watch the bots.
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74ee536827fa1558a29601be3959c1f109da5fd0 commit 74ee536827fa1558a29601be3959c1f109da5fd0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Jan 18 00:39:32 2019 Roll src/third_party/angle b3bdd2acc4f0..5fe7c5b92642 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/b3bdd2acc4f0..5fe7c5b92642 git log b3bdd2acc4f0..5fe7c5b92642 --date=short --no-merges --format='%ad %ae %s' 2019-01-17 ynovikov@chromium.org Include common/platform.h where used 2019-01-17 geofflang@chromium.org Reland "Don't call Texture::onDestroy twice for the zero textures." 2019-01-17 geofflang@chromium.org GL: Temporarily disable parallel shader compile. Created with: gclient setdep -r src/third_party/angle@5fe7c5b92642 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:922443 , chromium:922296 ,chromium:922936,chromium:849576 TBR=cwallez@chromium.org Change-Id: I970bdb5c71c8dd228901354565301076ca794675 Reviewed-on: https://chromium-review.googlesource.com/c/1418126 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623929} [modify] https://crrev.com/74ee536827fa1558a29601be3959c1f109da5fd0/DEPS
,
Today
(14 hours ago)
Has been green for 3 days or more; closing. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 16