https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1407465/1/smbprovider/proto.cc#91
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5a30cbf06df88c851268eeac7165cb89e36b1f9d commit 5a30cbf06df88c851268eeac7165cb89e36b1f9d Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Jan 19 08:14:00 2019 smbprovider: Add missing proto verifications to RemountOptionsProto - Adds verification checks for "workgroup", "username", and "mount_config" in RemountOptionsProto. - Update unit tests to reflect on this change. BUG=chromium:922266 TEST=emerges Change-Id: Icbea25f9fc6a51e2aa56a1442783ba58cf8e3c37 Reviewed-on: https://chromium-review.googlesource.com/1413999 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/5a30cbf06df88c851268eeac7165cb89e36b1f9d/smbprovider/smbprovider_test_helper.h [modify] https://crrev.com/5a30cbf06df88c851268eeac7165cb89e36b1f9d/smbprovider/proto_test.cc [modify] https://crrev.com/5a30cbf06df88c851268eeac7165cb89e36b1f9d/smbprovider/smbprovider_test.cc [modify] https://crrev.com/5a30cbf06df88c851268eeac7165cb89e36b1f9d/smbprovider/proto.cc [modify] https://crrev.com/5a30cbf06df88c851268eeac7165cb89e36b1f9d/smbprovider/smbprovider_test_helper.cc
Comment 1 by zentaro@chromium.org
, Jan 15