New issue
Advanced search Search tips

Issue 922261 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

'cros buildresult' started failing as of Jan. 14...

Project Member Reported by cmt...@chromium.org, Jan 15

Issue description

When we try to run cros buildresult from our role account, we get the following error:

$ cros buildresult --report json --buildbucket-id 8924369327032897568 --debug
15:01:23: DEBUG: Cache dir lookup.
15:01:23: DEBUG: Configured cache_dir to '/usr/local/google/crostc/chromeos/.cache'
15:01:23: INFO: RunCommand: /usr/local/google/crostc/chromeos/chromite/bin/cros_sdk --log-level debug -- /mnt/host/source/chromite/bin/cros buildresult --report json --buildbucket-id 8924369327032897568 --debug in /usr/local/google/crostc/chromeos
15:01:23: DEBUG: Configured cache_dir to '/usr/local/google/crostc/chromeos/.cache'
15:01:24: DEBUG: Configured cache_dir to '/usr/local/google/crostc/chromeos/.cache'
15:01:25: DEBUG: Cache dir lookup.
15:01:25: DEBUG: Configured cache_dir to '/mnt/host/source/.cache'
15:01:25: DEBUG: Using cached credentials /mnt/host/source/.cache/cidb_creds
15:01:25: INFO: Running cidb query on pid 8, repr(query) starts with 'SHOW DATABASES'
15:01:25: WARNING: /mnt/host/source/chromite/lib/cidb.py:237: Warning: 'NO_ZERO_DATE', 'NO_ZERO_IN_DATE' and 'ERROR_FOR_DIVISION_BY_ZERO' sql modes should be used with strict mode. They will be merged with strict mode in a future release.
  cur.execute("SET SESSION sql_mode='STRICT_ALL_TABLES'")

15:01:25: WARNING: /mnt/host/source/chromite/lib/cidb.py:237: Warning: Changing sql mode 'NO_AUTO_CREATE_USER' is deprecated. It will be removed in a future release.
  cur.execute("SET SESSION sql_mode='STRICT_ALL_TABLES'")

15:01:25: INFO: Created cidb engine readonly@104.197.188.23 for pid 8
15:01:25: INFO: Running cidb query on pid 8, repr(query) starts with 'SHOW TABLES'
15:01:26: INFO: Running cidb query on pid 8, repr(query) starts with 'SELECT MAX(schemaVersion) from schemaVersionTable'
15:01:26: INFO: Created a SchemaVersionedMySQLConnection, sqlalchemy version 0.9.2
15:01:27: INFO: Running cidb query on pid 8, repr(query) starts with <sqlalchemy.sql.selectable.Select at 0x7f7443bc0fd0; Select object>
15:01:30: ERROR: cros buildresult failed before completing.
cros: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/cros", line 170, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/cros", line 166, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 912, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/cros.py", line 66, in main
    code = _RunSubCommand(subcommand)
  File "/mnt/host/source/chromite/scripts/cros.py", line 51, in _RunSubCommand
    return subcommand.Run()
  File "/mnt/host/source/chromite/cli/cros/cros_buildresult.py", line 243, in Run
    build_statuses = [b for b in build_statuses if IsBuildStatusFinished(b)]
  File "/mnt/host/source/chromite/cli/cros/cros_buildresult.py", line 66, in IsBuildStatusFinished
    return build_status['status'] in _FINISHED_STATUSES
TypeError: list indices must be integers, not str

This was working up through Sunday...

 
Labels: -Pri-1 Pri-3
Owner: dhanyaganesh@chromium.org
Status: Assigned (was: Untriaged)
Potentially related to Dhanya's changes to the CIDB layer.

Comment 2 by lloz...@google.com, Jan 16 (6 days ago)

Jason, this is definetly not a P3. 
This blocks us from getting any results from our nightly testing. 
Since it is blocking a group of people and needs to be solved by this release, I believ e this is a P1.

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/83d975aac2b446e4f48f13283a848f7945e1066f

commit 83d975aac2b446e4f48f13283a848f7945e1066f
Author: Dhanya Ganesh <dhanyaganesh@chromium.org>
Date: Wed Jan 16 15:44:42 2019

cros_buildresult: Correcting a mistake with cidb changes.

Forgot the [0] first time around.

BUG= chromium:922261 
TEST=run_tests

Change-Id: Ieb06f0a23b91114e204636a614f93695d79d6708
Reviewed-on: https://chromium-review.googlesource.com/c/1413671
Commit-Queue: Dhanya Ganesh <dhanyaganesh@chromium.org>
Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org>
Trybot-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/83d975aac2b446e4f48f13283a848f7945e1066f/cli/cros/cros_buildresult.py

Comment 4 by jclinton@chromium.org, Jan 16 (6 days ago)

Labels: -Pri-3 Pri-2
It's actually P2 per SLO: https://docs.google.com/document/d/1ZAd3EZ3hCx9rWbXh4rcIRSF4ON-CXJ2T9revQGsxMXo/edit . That said, I believe that Dhanya has already fixed it. I'll let him comment.

Comment 5 by dhanyaganesh@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Assigned)
cros buildresult works fine now.

Comment 6 by lloz...@google.com, Jan 16 (6 days ago)

Thanks for the quick fix.

Comment 7 by dhanyaganesh@chromium.org, Jan 17 (5 days ago)

I made another change for cros buildresult and cros uprevchrome. I did a nominal query and it seems to be working fine. If you do notice any errors (especially related to BuildStore), I'll be the POC for it. Thanks.

Sign in to add a comment