New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 922252 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pre-fetch source file from gitiles/git and save to gcs for performance

Project Member Reported by liaoyuke@chromium.org, Jan 15

Issue description

In order to run fuzzer targets on swarming, the builder checks out internal code, to avoid the internal code being accidentally exposed to public, we should not blindly copy the source files from the builder to the gcs, instead, a better approach is to fetch the source files from gitles/git.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d1cd7b42d265e6ac2ae941aa4e9b1b01aa7d5730

commit d1cd7b42d265e6ac2ae941aa4e9b1b01aa7d5730
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Jan 16 17:25:40 2019

[code coverage] Add last_updated_revision to coverage proto

This field will be used by the service to decide if a previously
downloaded file can be reused or not, if not, a newer version will be
fetch and stored.

Bug: 922252
Change-Id: I11f8f8c7a3a12054deea03eda0ecdc17e06e2d7e
Reviewed-on: https://chromium-review.googlesource.com/c/1413590
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20022}
[modify] https://crrev.com/d1cd7b42d265e6ac2ae941aa4e9b1b01aa7d5730/appengine/findit/model/proto/gen/code_coverage_pb2.py
[modify] https://crrev.com/d1cd7b42d265e6ac2ae941aa4e9b1b01aa7d5730/appengine/findit/model/proto/code_coverage.proto

Comment 2 by liaoyuke@chromium.org, Jan 17 (5 days ago)

Summary: Pre-fetch source file from gitiles/git and save to gcs for performance (was: Retrieve source file from gitiles/git instead of copying from the builder)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0473c85428558afad969cc5bf69e14ac5b29e91c

commit 0473c85428558afad969cc5bf69e14ac5b29e91c
Author: Shuotao Gao <stgao@chromium.org>
Date: Fri Jan 18 17:31:24 2019

[code coverage] Add timestamp to proto definition.

Bug: 922252
Change-Id: Ia2efda4fca4d6fc19e618852fcdb86789223ed11
Reviewed-on: https://chromium-review.googlesource.com/c/1420617
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20074}
[modify] https://crrev.com/0473c85428558afad969cc5bf69e14ac5b29e91c/appengine/findit/model/proto/gen/code_coverage_pb2.py
[modify] https://crrev.com/0473c85428558afad969cc5bf69e14ac5b29e91c/appengine/findit/model/proto/code_coverage.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c852ef3787611d3c03d607bd339083cd6c2f1628

commit c852ef3787611d3c03d607bd339083cd6c2f1628
Author: Shuotao Gao <stgao@chromium.org>
Date: Fri Jan 18 22:53:10 2019

[code coverage] Add revision and timestamp for each file.

For each source file in the code coverage metadata, retrieve its revision and
timestamp from the Git repository it belongs to, and add them to the file
metadata.
"git ls-files" is used to retrieve committed files in each repository, and to detect generated files.
For generated files, no such metadata is added.
Note: running "git log" on a generated file takes too long.

Bug: 922252
Change-Id: I0023d2814576a65d60462b5affda771ae4a349f9
Reviewed-on: https://chromium-review.googlesource.com/c/1419877
Auto-Submit: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/c852ef3787611d3c03d607bd339083cd6c2f1628/scripts/slave/recipe_modules/clang_coverage/resources/repository_util.py
[modify] https://crrev.com/c852ef3787611d3c03d607bd339083cd6c2f1628/scripts/slave/recipe_modules/clang_coverage/unittests/generate_coverage_metadata_test.py
[modify] https://crrev.com/c852ef3787611d3c03d607bd339083cd6c2f1628/scripts/slave/recipe_modules/clang_coverage/resources/generate_coverage_metadata.py

Project Member

Comment 5 by bugdroid1@chromium.org, Yesterday (30 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b69a119fdb6c49f088c54b0c388a352f912727dc

commit b69a119fdb6c49f088c54b0c388a352f912727dc
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Jan 21 23:49:21 2019

[code coverage] Pre-fetch source files from gitiles and save to gcs

Fetching files from fitiles is slow, which results in slow rendering
of coverage file view, this CL improves the performance by prefetching
changed files between two revision and save it to gcs.

Bug: 922252
Change-Id: Iffca9ec70090651af60c4307284def2f1e25f71e
Reviewed-on: https://chromium-review.googlesource.com/c/1415576
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20102}
[add] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/handlers/test/code_coverage_test.py
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/handlers/flake/detection/flake_detection_utils.py
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/model/proto/code_coverage.proto
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/handlers/code_coverage.py
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/model/code_coverage.py
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/queue.yaml
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/index.yaml
[modify] https://crrev.com/b69a119fdb6c49f088c54b0c388a352f912727dc/appengine/findit/coverage_main.py

Sign in to add a comment