Autoroll feature request: link to roller dashboard? |
|||
Issue descriptionI was wondering if the autoroller email could link to the dashboard https://autoroll.skia.org/ in its emails. The reason is that for example right now, I got an email like this: " Subject: The last 3 Catapult into Chromium rolls have failed The roll is failing consistently. Time to investigate. The most recent roll attempt is here: https://chromium-review.googlesource.com/c/1412312 " I wanted to go check whether the latest roll was succeeding on the try bots that were failing before, but I couldn't figure out where the roller's dashboard is. I just figured out that it is linked to from one of the roller CLs: https://autoroll.skia.org/r/catapult-autoroll however, it would be nice if that link could be in the email as well since that would eliminate some searching around. If this feature is reasonable, I'm happy to attempt to implement it myself if someone can point me towards the code.
,
Jan 15
Looks like the code for it is at https://skia.googlesource.com/buildbot/+/master/autoroll/go/notifier/notifier.go
,
Jan 16
(6 days ago)
Ah, yeah, we should've been doing that all along. CL here: https://skia-review.googlesource.com/c/buildbot/+/184380
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b commit a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b Author: Eric Boren <borenet@google.com> Date: Wed Jan 16 13:01:51 2019 [autoroll] Include server URL in notification messages Bug: 922239 Change-Id: I6fe216214fa4048f1c7213cc57f0d44b88f56188 Reviewed-on: https://skia-review.googlesource.com/c/184380 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com> [modify] https://crrev.com/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b/autoroll/go/roller/config.go [modify] https://crrev.com/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b/autoroll/go/notifier/notifier.go [modify] https://crrev.com/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b/autoroll/go/roller/autoroller.go [modify] https://crrev.com/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b/autoroll/go/notifier/notifier_test.go [modify] https://crrev.com/a3f6fe34f58e648d4d00cd0a5a56cbf0d43b849b/autoroll/go/state_machine/state_machine_test.go
,
Jan 16
(6 days ago)
Ok, pushed the above change to the rollers. The next notification should include the server URL. Let me know if that's not the case!
,
Jan 16
(6 days ago)
Yay! Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by crouleau@chromium.org
, Jan 15