[Findit] Fix bugs in filing bugs for flake group |
||
Issue descriptioncontext: bug 921130 . Bugs need to be fix: 1. There is supposed to be a followup comment with the link to a page for all mentioned failures after a bug for a flake group creates, but it doesn't show up. Suspecting FD reaches daily threshold of updating bugs, but these comments should be special cases. 2. For flakes without suite, we should not group them in the first place.
,
Jan 15
Another thought, it already shows suite name might still be too strict to group flakes, we can just remove suite and using normalized_step_name(target_name) directly.
,
Jan 15
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/67f3cb7e9d805a4fb3487c37e12a666b049c6661 commit 67f3cb7e9d805a4fb3487c37e12a666b049c6661 Author: Chan <chanli@chromium.org> Date: Fri Jan 18 22:23:30 2019 [Findit] Include a comment immediately after a bug for a group of flakes is created. Bug: 922235 Change-Id: Ice268037264e40ed771ba82b4e289055e6d593e3 Reviewed-on: https://chromium-review.googlesource.com/c/1413591 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#20084} [modify] https://crrev.com/67f3cb7e9d805a4fb3487c37e12a666b049c6661/appengine/findit/services/test/monorail_util_test.py [modify] https://crrev.com/67f3cb7e9d805a4fb3487c37e12a666b049c6661/appengine/findit/services/flake_issue_util.py [modify] https://crrev.com/67f3cb7e9d805a4fb3487c37e12a666b049c6661/appengine/findit/services/monorail_util.py [modify] https://crrev.com/67f3cb7e9d805a4fb3487c37e12a666b049c6661/appengine/findit/services/test/flake_issue_util_test.py |
||
►
Sign in to add a comment |
||
Comment 1 by chanli@chromium.org
, Jan 15