New issue
Advanced search Search tips

Issue 922188 link

Starred by 1 user
Status: Duplicate
Owner:
wolenetz@chromium.org
Closed: Jan 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Suppress OnBufferingStateChange log spam in media_pipeline_integration_fuzzer

Project Member Reported by wolenetz@chromium.org, Jan 15 
SRC= media_pipeline_integration_fuzzer, in some cases, can emit spammy log messages which need suppression:

Actual function call count doesn't match EXPECT_CALL(*this, OnBufferingStateChange(BUFFERING_HAVE_ENOUGH))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

See bug 918509 for such a case.

Comment 1 by wolenetz@chromium.org, Jan 15 

CF logs confirm this is happening right now, frequently.

Root cause is the fuzzed pipeline integration test issues a seek, and the test base requires BUFFERING_HAVE_ENOUGH to be reached at some later point (https://cs.chromium.org/chromium/src/media/test/pipeline_integration_test_base.cc?q=pipeline_integration_test_base.cc&sq=package:chromium&dr&l=358).

But not all fuzzed media allows seek to complete with enough subsequent media for the pipeline to signal having enough data.

This expectation for having enough data is entangled with a side effect in the test that quits the runloop, followed by allowing any subsequent number of buffering state changes. Disentangling just for the fuzzer might require a helper that the OnBufferingStateChange mock calls, which will quit the runloop conditionally.

Comment 2 by wolenetz@chromium.org, Jan 16 (6 days ago)

Mergedinto: 894460
Status: Duplicate (was: Assigned)
See especially https://bugs.chromium.org/p/chromium/issues/detail?id=894460#c26 and potentially root cause https://bugs.chromium.org/p/chromium/issues/detail?id=915923
►

Sign in to add a comment