New issue
Advanced search Search tips

Issue 922186 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Yesterday
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

toolchain-utils: Go compiler test scripts are hard-coded to be board-specific.

Project Member Reported by cmt...@chromium.org, Jan 15

Issue description

The current scripts for testing the Go compiler are hard-coded to only allow testing on elm and chell. This needs to be changed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5e390bb543637eb9cd80ce1584f21d161b92097e

commit 5e390bb543637eb9cd80ce1584f21d161b92097e
Author: Caroline Tice <cmtice@google.com>
Date: Sat Jan 19 08:13:58 2019

toolchain-utils: Update scripts for testing Go compiler.

The current scripts for testing the Go compiler were hard-coded to
only chell and elm.  This CL creates a setup script that will allow
the user to specify any boards, and will automatically generate the
appropriatye board-specific scripts (and clean up afterwards if
requested. It also deletes the hard-coded scripts, and it adds
the appropriate testing_rsa to various scp/ssh commands to avoid
interactive password prompts.

BUG= chromium:922186 
TEST=Used these scripts during recent Go compiler verification and
upgrade.

Change-Id: Ie55b8a5ce30ecf00976ce27756473a238cc78c02
Reviewed-on: https://chromium-review.googlesource.com/1412836
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/5e390bb543637eb9cd80ce1584f21d161b92097e/go/chromeos/setup_chromeos_testing.py
[modify] https://crrev.com/5e390bb543637eb9cd80ce1584f21d161b92097e/go/chromeos/push_glibc
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_elm32_exec
[modify] https://crrev.com/5e390bb543637eb9cd80ce1584f21d161b92097e/go/chromeos/target_cp
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_elm_exec
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_chell_exec
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_elm32
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_elm
[delete] https://crrev.com/9bc678e0a879e80e187dfdf27e3b87b39df027a5/go/chromeos/go_chell
[modify] https://crrev.com/5e390bb543637eb9cd80ce1584f21d161b92097e/go/chromeos/target_sh

Comment 2 by cmtice@google.com, Yesterday (36 hours ago)

Status: Verified (was: Started)

Sign in to add a comment