New issue
Advanced search Search tips

Issue 922143 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 922663



Sign in to add a comment

Fuchsia: Remove libswiftshader_libGLESv2.so from published chromium package, or make optional

Project Member Reported by jamesr@google.com, Jan 15

Issue description

libswiftshader_libGLESv2.so is currently included in the chromium package uploaded for Fuchsia to support running GLESv2-based content, but it isn't needed in all configurations and occupies a large chunk of space (14MB).  We should either remove it from the package or provide packages with and without this library.
 

Comment 1 by sergeyu@chromium.org, Jan 16 (6 days ago)

Components: Internals>PlatformIntegration
Labels: M-74
Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)
We will still need to include swiftshader in content_shell for layout tests.
I think we will need to add an exclusion list parameter for fuchsia package targets and then exclude libswiftshader_libGLESv2.so from the web_engine package (aka chromium.far)

Comment 2 by w...@chromium.org, Jan 16 (6 days ago)

Blocking: 922663

Comment 3 by w...@chromium.org, Jan 16 (6 days ago)

Please update US-577 when this is addressed.

Comment 4 by w...@chromium.org, Jan 16 (6 days ago)

Labels: -Pri-2 Pri-1

Comment 5 by sergeyu@chromium.org, Jan 17 (5 days ago)

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8a3c6e4919200eb076e3678d1bfb349832c2d76

commit e8a3c6e4919200eb076e3678d1bfb349832c2d76
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jan 18 03:10:09 2019

[Fuchsia] Exclude swiftshader libraries from the engine package

The swiftshader libraries add significant amount of bloat to the
engine package (aka chromium.cmx), but they are not needed there.
Added --exclude-file flag in build_manifest.py that allows to exclude
runtime dependencies from the output package.
Also updated build_manifest.py to use named rather than positional
arguments, which makes it less error-prone.

Bug: 922143
Change-Id: I1b88c09404f400fba1eb32196a6437683fea1d1e
Reviewed-on: https://chromium-review.googlesource.com/c/1418518
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623982}
[modify] https://crrev.com/e8a3c6e4919200eb076e3678d1bfb349832c2d76/build/config/fuchsia/build_manifest.py
[modify] https://crrev.com/e8a3c6e4919200eb076e3678d1bfb349832c2d76/build/config/fuchsia/package.gni
[modify] https://crrev.com/e8a3c6e4919200eb076e3678d1bfb349832c2d76/fuchsia/BUILD.gn

Sign in to add a comment