Remove vulkan validation layers from production Fuchsia chromium package |
||||
Issue descriptionThe chromium package uploaded for Fuchsia currently contains all of the vulkan validation layers, which are useful for development but not needed for production and fairly large. We should remove these from the distributed package.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
Please update US-577 when this is addressed.
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12cc899e71aae6032d6eec4172a4e755c71cb5f3 commit 12cc899e71aae6032d6eec4172a4e755c71cb5f3 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Jan 17 05:23:09 2019 [Fuchsia] Exclude vulkan validation layers from release builds. Previously build_package.py was including all .so libs from the sdk/arch/dist directory. This includes vulkan validation layer libraries that are used only in debug builds. This CL restores the original logic in build_package.py that ensures that we only include libraries from sdk/arch/dist when they are used by the main application binary, or a transitive dependency. The vulkan libraries now are pulled as data_deps in //gpu/vulkan. The validation layer is included only in debug builds, which makes release packages smaller. Bug: 861931, 922139 Change-Id: I9d7fdbc451194da6013cdde9a32500cd6767d28b Reviewed-on: https://chromium-review.googlesource.com/c/1416834 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#623592} [modify] https://crrev.com/12cc899e71aae6032d6eec4172a4e755c71cb5f3/build/config/fuchsia/build_manifest.py [modify] https://crrev.com/12cc899e71aae6032d6eec4172a4e755c71cb5f3/gpu/vulkan/BUILD.gn [modify] https://crrev.com/12cc899e71aae6032d6eec4172a4e755c71cb5f3/third_party/fuchsia-sdk/BUILD.gn
,
Jan 17
(5 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sergeyu@chromium.org
, Jan 16 (6 days ago)Owner: sergeyu@chromium.org
Status: Assigned (was: Untriaged)