New issue
Advanced search Search tips

Issue 922138 link

Starred by 3 users
Status: WontFix
Owner:
amusbach@chromium.org
Closed: Today
Cc:
omrilio@chromium.org
x...@chromium.org
zork@chromium.org
edcourtney@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Arc app window becomes unsnappable when chrome caption is enabled

Project Member Reported by x...@chromium.org, Jan 15 
Chrome Version: 73.0.3672.0
OS: Chrome

This issue stems from https://buganizer.corp.google.com/issues/78198191 and seems to be a regression.

What steps will reproduce the problem?
(1) Open android settings, enable developer options, and "enable chrome caption" option
(2) Open any N- resizable ARC++ app (Eg. Youtube, Gmail etc)
(3) Long press maximize/resize button to trigger snap buttons.

What is the expected result?
Snap buttons should show up and the app should be snappable

What happens instead?
Snap buttons do not show up and the app can't be snapped


The reason the snap button do not show up is when chrome caption is enabled, WindowState::CanSnap() returns false, which is because WindowState::HasMaximumWidthOrHeight() returns true.

The maximize height of the ARC app window when the chrome caption is enabled is 32, which is the caption height.

Comment 1 by x...@chromium.org, Jan 15

Cc: zork@chromium.org
Owner: amusbach@chromium.org
Status: Assigned (was: Untriaged)
So it looks like the maximize size of the ARC app window is incorrect in this case. 

The maximum size of the ARC app window is obtained from CustomFrameView::GetMaximumSize() function (see https://cs.chromium.org/chromium/src/components/exo/shell_surface_base.cc?rcl=8ee8373ae9828abad9ed511dff1fddaac7479955&l=212). The top border height is taken into consideration here. I don't think we should do so if |maximize_size| is an empty size. (empty size means there is no maximize size limit here). 

Assign to Avery for further investigation. There might be more problems here even after the snap buttons show up, the Arc app window should be able to snap to left or right successfully.

Comment 2 by osh...@chromium.org, Jan 18 (4 days ago)

Cc: edcourtney@chromium.org
maybe this is dup of b/123043420?

Comment 3 by x...@chromium.org, Jan 18 (4 days ago) 

Yes, part of this issue is dup of b/123043420. With that fix, now the snap buttons can show up correctly (tested locally before), however, snapping it to left/right still has some other problem and needs to be investigated.

Comment 4 by amusbach@chromium.org, Today (11 hours ago)

Status: WontFix (was: Assigned)

Comment 5 by x...@chromium.org, Today (6 hours ago) 

Issue 924356 has been merged into this issue.
►

Sign in to add a comment