New issue
Advanced search Search tips

Issue 922129 link

Starred by 1 user
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Jan 16
Cc:
weidongg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK fail between launcher -> overview transition if animation is still running.

Project Member Reported by sammiequon@chromium.org, Jan 15 
What steps will reproduce the problem?
(0) build chrome with DCHECK
(1) Tablet mode -> open one window.
(2) Press launcher button to animate away window.
(3) Hit F5/overview tray before the window finishes animating.

What is the expected result?
Enter Overview

What happens instead?
DCHECK hit - and crash if DCHECK removed

Comment 1 by sammiequon@chromium.org, Jan 15 

77441:77441:0115/103841.245582:FATAL:window_selector.cc(380)] Check failed: enter_exit_overview_type_ != EnterExitOverviewType::kSwipeFromShelf (2 vs. 2)
#0 0x557877a16cdf base::debug::StackTrace::StackTrace()
#1 0x55787797a1ca logging::LogMessage::~LogMessage()
#2 0x55787a176816 ash::WindowSelector::Init()
#3 0x55787a0724a0 ash::WindowSelectorController::ToggleOverview()
#4 0x55787a09f164 ash::AcceleratorController::PerformAction()
#5 0x55787a09fc11 ash::AcceleratorController::AcceleratorPressed()
#6 0x55787ba6ed9a ui::AcceleratorManager::Process()
#7 0x55787a0a4451 ash::PreTargetAcceleratorHandler::ProcessAccelerator()
#8 0x55787bde3c91 wm::AcceleratorFilter::OnKeyEvent()
#9 0x55787846d992 ui::EventDispatcher::DispatchEventToEventHandlers()
#10 0x55787846d5bc ui::EventDispatcher::ProcessEvent()
#11 0x55787846d485 ui::EventDispatcherDelegate::DispatchEventToTarget()
#12 0x55787846d3e0 ui::EventDispatcherDelegate::DispatchEvent()
#13 0x55787bad7a52 ui::EventProcessor::OnEventFromSource()
#14 0x5578790aff56 aura::WindowTreeHost::DispatchKeyEventPostIME()
#15 0x557879fcf2d5 ash::WindowTreeHostManager::DispatchKeyEventPostIME()
#16 0x55787bc05591 ui::InputMethodBase::DispatchKeyEventPostIME()
#17 0x55787bc06738 ui::InputMethodChromeOS::ProcessUnfilteredKeyPressEvent()
#18 0x55787bc0646e ui::InputMethodChromeOS::DispatchKeyEvent()
#19 0x55787bc068bf ui::InputMethodChromeOS::DispatchKeyEvent()
#20 0x5578790a7e19 aura::WindowEventDispatcher::PreDispatchEvent()
#21 0x55787846d3b6 ui::EventDispatcherDelegate::DispatchEvent()
#22 0x55787bad7a52 ui::EventProcessor::OnEventFromSource()
#23 0x55787a21c047 ws::EventQueue::DeliverOrQueueEvent()
#24 0x557879fd751a ash::AshWindowTreeHostPlatform::DeliverEventToSink()
#25 0x55787846e4c8 ui::EventSource::SendEventToSinkFromRewriter()
#26 0x5578790b211e aura::WindowTreeHostPlatform::DispatchEvent()
#27 0x557879fd73d8 ash::AshWindowTreeHostPlatform::DispatchEvent()
#28 0x5578784713c7 ui::DispatchEventFromNativeUiEvent()
#29 0x557874e4e06e ui::X11WindowOzone::DispatchEvent()
#30 0x5578780bc563 ui::PlatformEventSource::DispatchEvent()
#31 0x557878cfca49 ui::X11EventSourceLibevent::DispatchPlatformEvent()
#32 0x557878cfc501 ui::X11EventSourceLibevent::ProcessXEvent()
#33 0x557878cfd310 ui::X11EventSource::DispatchXEvents()
#34 0x557877a3520c base::MessagePumpLibevent::OnLibeventNotification()
#35 0x557877a596ed event_base_loop
#36 0x557877a353ae base::MessagePumpLibevent::Run()
#37 0x5578779829d8 base::MessageLoopImpl::Run()
#38 0x5578779a9525 base::RunLoop::Run()
#39 0x55787753138b ChromeBrowserMainParts::MainMessageLoopRun()
#40 0x55787537c2d4 content::BrowserMainLoop::RunMainMessageLoopParts()
#41 0x55787537e8e6 content::BrowserMainRunnerImpl::Run()
#42 0x557875378efe content::BrowserMain()
#43 0x5578774f85cc content::ContentMainRunnerImpl::RunServiceManager()
#44 0x5578774f81d1 content::ContentMainRunnerImpl::Run()
#45 0x55787752a403 service_manager::Main()
#46 0x5578774f6634 content::ContentMain()
#47 0x5578743aa353 ChromeMain
#48 0x7f92c74dc2b1 __libc_start_main
#49 0x5578743aa1ca _start
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc5cc5f3e3da3f0126fea719130141209a1c796

commit abc5cc5f3e3da3f0126fea719130141209a1c796
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Jan 16 01:36:23 2019

applist: Fix DCHECK if toggle overview while home launcher still animating.

Test: Added test which failed before this change
Bug:  922129 
Change-Id: I350ad4f5cc375eb512ffb9c3c040716f2445c41c
Reviewed-on: https://chromium-review.googlesource.com/c/1412936
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622987}
[modify] https://crrev.com/abc5cc5f3e3da3f0126fea719130141209a1c796/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/abc5cc5f3e3da3f0126fea719130141209a1c796/ash/app_list/home_launcher_gesture_handler.h
[modify] https://crrev.com/abc5cc5f3e3da3f0126fea719130141209a1c796/ash/app_list/home_launcher_gesture_handler_unittest.cc

Comment 3 by sammiequon@chromium.org, Jan 16

Status: Fixed (was: Assigned)
►

Sign in to add a comment