CaptivePortal Window in login screen should not be "child" |
|
Issue descriptionIt's currently added as a child of the web content's host window. Since it acts as a toplevel window, it shouldn't use child window. Instead, it should be either just a modal dialog, or transient child. https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/captive_portal_window_proxy.cc?rcl=2aa2303669972f7f150b4eab9aafeaab11e3262d&l=27 I tried just removing them, but it causes different crashes in both classic ash and single process mash. rkc@ can someone in your team look into this as a part of OOBE/Login refactoring? I'm happy to help to diagnose the issue.
,
Jan 15
Looks like it's opened as a web modal dialog (of gaia login page?) and that seems to be causing the issue (at least in classic ash). I guess they're unrelated? (the login page is probably just a trigger). If so, it can be just a normal modal dialog.
,
Jan 15
Hi Mitsuru, I authored the original handling code for the captive portal dialog in views login. I agree -- I think the popup can be implemented similar to how the OOBe dialog is done (https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h) I'll look into this after some other more urgent stuff I'm working on. Will get your thoughts on it then! |
|
►
Sign in to add a comment |
|
Comment 1 by jdufault@chromium.org
, Jan 15Status: Assigned (was: Available)