New issue
Advanced search Search tips

Issue 922063 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CL +1s from mthiesse@chromium.org not being recognized by presubmit

Project Member Reported by mthiesse@google.com, Jan 15

Issue description

Recently presubmit has stopped recognizing my +1s on CLs, and reviewers have to TBR me after I +1 to submit their CLs.

Examples:
https://chromium-review.googlesource.com/c/chromium/src/+/1409817
https://chromium-review.googlesource.com/c/chromium/src/+/1401279
 

Comment 1 by mthiesse@chromium.org, Jan 16 (6 days ago)

Components: Infra>Client>Chrome

Comment 2 by sergeybe...@chromium.org, Jan 16 (6 days ago)

Is this happening consistently? Or flakily?

Sample log from chromium-presubmit: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8924251487815163072/+/steps/presubmit/0/stdout

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
    chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
    chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java

The bot ran at 2019-01-15 7:53 AM (PST), the +1 was added at 7:48am (5 min prior). The OWNERS file seem to be correct (especially if it worked earlier).

Either the presubmit script changed somehow and doesn't understand the file inclusions in OWNERS files, or Gerrit is not reporting the +1 in time.

I'll try to triage this someplace more specific a bit later.

Comment 3 by mthiesse@chromium.org, Jan 16 (6 days ago)

Appears to be consistent.

Comment 4 by ajp@chromium.org, Jan 17 (5 days ago)

Cc: tandrii@chromium.org
Andrii - Given the theory of "Gerrit is not reporting the +1 in time" could this be a symptom of http://b/122924821 ?

Comment 5 by mthiesse@chromium.org, Jan 17 (5 days ago)

I doubt it, though it's possible. In many tries, only my +1 didn't count - the other reviewer's +1s did count, and it hasn't been flaky.

Comment 6 by jbudorick@chromium.org, Jan 17 (5 days ago)

Components: -Infra>Client>Chrome Infra>SDK
This seems likely to either be a gerrit issue or an issue w/ presubmit support provided by depot_tools; updating components accordingly.

Comment 7 by tandrii@chromium.org, Jan 17 (5 days ago)

Cc: -tandrii@chromium.org
"Gerrit is not reporting the +1 in time"  is primarily to do with +1 vote not making it to Gerrit index immediately upon backends accepting an update.

presubmit tooling in depot_tools afair fetches data about gerrit CL w/o using Gerrit index, but asking the source of truth -- gerrit backend.

OTH, gerrit backend actually has replicas, and if one is really stale, then yeah, this can be the case (see also http://b/122858799)

[removing myself because nothing to do with CQ]

Comment 8 by mthiesse@chromium.org, Jan 17 (5 days ago)

Status: Closed (was: Untriaged)
Seems like my +1s are working again, will re-open if they start failing.

Sign in to add a comment