New issue
Advanced search Search tips

Issue 922041 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 921342



Sign in to add a comment

Catapult roll failing telemetry_perf_unittests - process_perf_results_unittest.ProcessPerfResultsIntegrationTest.testIntegration

Project Member Reported by jmadill@google.com, Jan 15

Issue description

Looks like the rolls have been failing for more than a day. At least all the rolls present in the auto-roller dashboard:

https://autoroll.skia.org/r/catapult-autoroll

The test is failing on linux_chromium_rel_ng, android-marshmallow-arm64-rel, and possibly other configs.

Example builds:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/167532
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/271715
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/271790

Example CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1409094

The failing test is always "process_perf_results_unittest.ProcessPerfResultsIntegrationTest.testIntegration" in "telemetry_perf_unittests".

Brian can you help triage this? I don't know who the right sheriff is for capapult, is that the perf sheriff? This is blocking fixing gtest test scaling.
 
Cc: sullivan@chromium.org
+Annie who is perf sheriff in case that's the right person.
Owner: benjhayden@chromium.org
Ben, can you triage? It looks like it's been failing since this roll:
https://chromium-review.googlesource.com/c/chromium/src/+/1407872

Which has 2 of your CLs:
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.
Remove TagMap was reverted. Now trying to figure out how to repro before relanding.
Command to run is:

./tools/perf/run_tests --test-filter=process_perf_results_unittest.ProcessPerfResultsIntegrationTest.testIntegration

I think
Cc: -sullivan@chromium.org
perfbot-sheriff would be the right person, but there's no perfbot sheriff right now :(. Working on it.
Owner: perezju@chromium.org
Status: Fixed (was: Assigned)
The new roll is passing: https://chromium-review.googlesource.com/c/chromium/src/+/1413252

Thanks Juan for the revert!
Yes, thank you for unblocking the roller.

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Comment 10 by perezju@google.com, Jan 17 (5 days ago)

No problem. Also, sorry for submitting one of the CLs that contributed to the breakage. 😅

Sign in to add a comment