New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 922028 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 902878



Sign in to add a comment

App bundles: Specify list of uncompressed files in BundleConfig.js file

Project Member Reported by digit@google.com, Jan 15

Issue description

bundletool 0.8.0 just got released and contains a breaking change!

"""
Bundletool will no longer keep a list of extensions of files which must remain uncompressed by default in the generated APKs; it's up to the build system calling build-bundle to specify those files in the BundleConfig. Applies only to App Bundles built with version 0.8.0+ of bundletool.
"""

According to bundletool's author, the previous list was "3g2", "3gp", "3gpp", "3gpp2", "aac", "amr", "awb", "gif", "imy", "jet", "jpeg", "jpg", "m4a", "m4v", "mid", "midi", "mkv", "mp2", "mp3", "mp4", "mpeg", "mpg", "ogg", "png", "rtttl", "smf", "wav", "webm", "wma", "wmv", "xmf".

We need to add a corresponding list to _GenerateBundleConfigJson() in build/android/gyp/create_app_bundle.py


 
Blocking: 902878
This is blocking 902878 which requires bundletool 0.8.0 for a different reason.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7eaaf6f10aec9f024a4b3ab12923c146ee82d2

commit 6a7eaaf6f10aec9f024a4b3ab12923c146ee82d2
Author: David 'Digit' Turner <digit@google.com>
Date: Thu Jan 17 11:06:14 2019

android: Ensure bundles do not compressed files by mistake.

The newest version of bundletool (0.8.0) contains a breaking
change, requiring the build to specify which files stored in the
bundle should not be compressed in the final output.

This CL adds the original list of file extensions that were
previously automatically handled by bundletool to deal with
that.

BUG=922028
R=agrieve@chromium.org,estevenson@chromium.org,benmason@chromium.org

Change-Id: I995469199c7185a2039d1b45feb33da78704414d
Reviewed-on: https://chromium-review.googlesource.com/c/1411779
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623642}
[modify] https://crrev.com/6a7eaaf6f10aec9f024a4b3ab12923c146ee82d2/build/android/gyp/create_app_bundle.py

Sign in to add a comment