Implement an API alternative to PO2TS::LoadCredentials in IdentityManager |
||||||
Issue descriptionAPI is used by (production): chrome/browser/supervised_user/supervised_user_service.cc .. and in various unit tests, eg account_reconcilor_unittest.cc
,
Jan 15
The production use cases should go now, so for those let's just add IdentityManager::LegacyLoadCredentials(). It can have the same implementation (and test) that was previously present for AccountsMutatorImpl. The test use cases should be covered by an identity_test_utils/IdentityTestEnvironment API.
,
Jan 16
,
Jan 17
(5 days ago)
,
Jan 18
(4 days ago)
,
Jan 18
(4 days ago)
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01aa03e4c4e7ecbd1dd9895948db03666ef237db commit 01aa03e4c4e7ecbd1dd9895948db03666ef237db Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Jan 18 10:49:16 2019 [s13n] Add LegacyLoadCredentials() to IdentityManager This CL adds LegacyLoadCredentials to IdentityManager in order to help s13n IdentityManager migration. It will be used for replacing ProfileOAuth2TokenService::LoadCredentials(). Bug: 922019 Change-Id: Ie74bc4b21ffb968ff6de83eab1aba5a16417135a Reviewed-on: https://chromium-review.googlesource.com/c/1412775 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#624062} [modify] https://crrev.com/01aa03e4c4e7ecbd1dd9895948db03666ef237db/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/01aa03e4c4e7ecbd1dd9895948db03666ef237db/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/01aa03e4c4e7ecbd1dd9895948db03666ef237db/services/identity/public/cpp/identity_manager_unittest.cc
,
Yesterday
(30 hours ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by toniki...@chromium.org
, Jan 15