Implement an API alternative to PO2TS::AreAllCredentialsLoaded in IdentityManager |
||||
Issue descriptionIt is used in two places: chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc components/signin/core/browser/account_reconcilor.cc There is a testing API alternative for it, but not available in production code: identity::AreAllCredentialsLoaded @ services/identity/public/cpp/identity_test_utils.cc I offer to work on it, but would like to hear about API owners first on the way forward.
,
Jan 15
Yes, let's just move AreAllCredentialsLoaded() to IdentityManager::AreAccountsLoadedFromDisk(). Thanks!
,
Jan 16
(6 days ago)
,
Jan 17
(5 days ago)
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad2a0961ae22ba1d23cebfbbc104c737f64cd392 commit ad2a0961ae22ba1d23cebfbbc104c737f64cd392 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Jan 18 03:01:53 2019 [s13n] Move AreAllCredentialsLoaded to IdentityManager This CL moves AreAllCredentialsLoaded to IdentityManager from identity_test_utils.cc to make it available in production code and renames it to AreRefreshTokensLoaded. Bug: 922017 Change-Id: I6f6f20158d31cab1cef973ee340ba5f5ac810e33 Reviewed-on: https://chromium-review.googlesource.com/c/1411964 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#623976} [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/services/identity/public/cpp/identity_manager_unittest.cc [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/services/identity/public/cpp/identity_test_utils.cc [modify] https://crrev.com/ad2a0961ae22ba1d23cebfbbc104c737f64cd392/services/identity/public/cpp/identity_test_utils.h
,
Jan 18
(5 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by toniki...@chromium.org
, Jan 15