New issue
Advanced search Search tips

Issue 921965 link

Starred by 2 users
Status: Fixed
Owner:
fbeaufort@chromium.org
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Play/pause button in Picture-in-Picture window is not always visible for src= video

Project Member Reported by fbeaufort@chromium.org, Jan 15 
Chrome Version       : 73.0.3669.0
OS Version: 11582.0.0

What steps will reproduce the problem?
1. Go to https://beaufortfrancois.github.io/sandbox/media/picture-in-picture-playground
2. Click "Toggle Picture-in-Picture" button
3. Play/pause button is visible in Picture-in-Picture window
4. Click "Toggle MediaStream" button
5. Play/pause button is NOT visible in Picture-in-Picture window
6. Click "Toggle MediaStream" button

What is the expected result?
Play/pause button is visible in Picture-in-Picture window

What happens instead of that?
Play/pause button is NOT visible in Picture-in-Picture window
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073

commit 7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Fri Jan 18 06:57:47 2019

Fix play/pause button visibility in Picture-in-Picture window

This CL makes sure play/pause button is visible in Picture-in-Picture
window if previous video was a MediaStream.

Bug:  921965 
Change-Id: I7117f6b4fdbdb7538e3d7fac010ec849056f7c80
Reviewed-on: https://chromium-review.googlesource.com/c/1411342
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624025}
[modify] https://crrev.com/7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073/chrome/browser/picture_in_picture/DEPS
[modify] https://crrev.com/7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073/chrome/test/data/media/picture-in-picture/window-size.html

Comment 3 by fbeaufort@chromium.org, Today (20 hours ago)

Status: Fixed (was: Started)
Fixed in Chrome 73.0.3676.0
►

Sign in to add a comment