New issue
Advanced search Search tips

Issue 921929 link

Starred by 1 user
Status: Fixed
Owner:
hkamila@chromium.org
Closed: Yesterday
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unwanted blue focus ring is seen after clicking on text under chrome://settings/content/flash

Project Member Reported by vineet...@virtusa.com, Jan 15 
Chrome Version : 73.0.3671.0 (Official Build) Revision d2dfa7d40588461802e7e6dca7d86b583060eda9-refs/branch-heads/3671@{#1} (32/64 bit)
OS : Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3) and Linux(14.04 LTS) OS

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/content/flash
2. Click on the text "Your flash settings will be ..." and observe.

Actual Result   : Unwanted blue focus ring is seen after clicking on text under chrome://settings/content/flash.
Expected Result : Blue focus ring should not be seen after clicking on text under chrome://settings/content/flash.

This is a regression issue broken in M-71 and below is the per-revision bisect information:
Good Build : 71.0.3557.0 (Revision : 592638)
Bad Build  : 71.0.3558.0 (Revision : 593042)

You are probably looking for a change made after 592744 (known good), but no later than 592745 (first known bad).

CHANGE-LOG URL

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ddebb97f7d4e9592317fd3a4aa5bd2be93432eb9..823a4544bd8192e49ba251c50cf4059d5d88b7c3

Suspect: https://chromium.googlesource.com/chromium/src/+/823a4544bd8192e49ba251c50cf4059d5d88b7c3

@hkamila: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer attached screen cast.
ActualVideo.mp4
228 KB View Download
ExpectedVideo.mp4
221 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Yesterday (38 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abfea4aea4c461f7342ee42116c237281d0740fd

commit abfea4aea4c461f7342ee42116c237281d0740fd
Author: Kamila <hkamila@google.com>
Date: Mon Jan 21 16:09:18 2019

Removed unwanted blue focus ring

Fixed the regression bug, about removing the unwanted focus blue ring  which
is seen after clicking on text under chrome://settings/content/flash.

Bug:  921929 
Change-Id: I248f86cf2172daeed59f9c18551142ef519746ae
Reviewed-on: https://chromium-review.googlesource.com/c/1412939
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624596}
[modify] https://crrev.com/abfea4aea4c461f7342ee42116c237281d0740fd/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 2 by hkamila@google.com, Yesterday (37 hours ago)

Status: Fixed (was: Assigned)

Comment 3 by vineet...@virtusa.com, Today (19 hours ago)

Labels: TE-Verified-M73 TE-Verified-73.0.3680.0
Update:

Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3) and Linux(14.04 LTS)OS using latest Canary build #73.0.3680.0 and the issue is fixed. Kindly refer attached screen cast.

Thank you
FixedVideo.mp4
202 KB View Download
►

Sign in to add a comment