New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 921910 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Do file bugs post-analysis

Project Member Reported by michae...@chromium.org, Jan 15

Issue description

Link to Culprit: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMTUzZjc0ZjhjZDM3ZjYwNmU0N2U5YWNmOGFjNGI5ZjhkZTJmODgyMQw

This CL removed a flag (that wasn't used by any code that was being called outside of tests) and updated CrOS Chromium browser_tests, so it can't have affected webkit layout tests.
 
Labels: Type-Bug
I got assigned *23* (so far) bugs for flaky tests on Mac. (My CL only affects CrOS Chromium.) I understand false positives are unavoidable, but do you really have to file a separate bug for each test?
Owner: lijeffrey@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for reporting this to me.

lijeffrey@, could you take a look? I though we should only file one bug for each culprit?
Hi Michael, sorry for the spam! The cause is Findit has code that files bugs for each flaky test analysis that identifies a culprit, which is to be deprecated.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a0e70057605ad74e0f59eca06591323db3394766

commit a0e70057605ad74e0f59eca06591323db3394766
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Jan 15 22:42:51 2019

[Findit] Flake Analyzer - Deprecate CreateBugForFlakePipeline

Removes CreateBugForFlakePipeline entirely. Note with this change, FlakeAnalyses
that identify culprits via CI failure analysis will not have bugs associated. The
downtime for bugs being logged for CI failures is expected to be minimal, as chanli@
is currently working on routing them through FlakeDetection which will handle bug
filing before analyses begin. Culprits identified will still be notified as before.

Bug:  921910 
Change-Id: I7754cdabf353114ff8e4acdbc4fbce4d9ae249be
Reviewed-on: https://chromium-review.googlesource.com/c/1413434
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20001}
[delete] https://crrev.com/3955a7cf4d9ede4e48b29491726d73536f1318a0/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[delete] https://crrev.com/3955a7cf4d9ede4e48b29491726d73536f1318a0/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/a0e70057605ad74e0f59eca06591323db3394766/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/a0e70057605ad74e0f59eca06591323db3394766/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py

Status: Fixed (was: Assigned)
Summary: [Findit] Flake Analyzer - Do file bugs post-analysis (was: [Findit] Flake Analyzer - Wrong culprit r622639)
Thank you!

Has this always been an issue? What was the impetus to deprecate this behavior if so?
Hi Michael, we are in a process of redesigning and refactoring our products, and this deprecation was in plan but waiting for another feature. Now since the pipeline has become troublesome, we decided to deprecate it a little earlier (the blocking feature is almost ready, so it seems fine to do so.)

Sign in to add a comment