New issue
Advanced search Search tips

Issue 921908 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 805271



Sign in to add a comment

::after and ::before don't work with ::part

Project Member Reported by fergal@chromium.org, Jan 15

Issue description

E.g.

// add an asterisk prefix to the title part
x-foo::part(title)::before {
    content: '*';
    color: red;
    margin-right: 0.25rem;
}

Should work to add a `*` before the title.
 
040keyframes fb.docx
348 KB Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9548726e0ee796ac2b5ec56bba2226aab7cff5f1

commit 9548726e0ee796ac2b5ec56bba2226aab7cff5f1
Author: Fergal Daly <fergal@chromium.org>
Date: Wed Jan 16 08:49:53 2019

[CSS] Refactor a series of ifs into a switch statement.

Bug:  921908 
Change-Id: I8994b61e2a1fd0d165f426417b513718dcb7257a
Reviewed-on: https://chromium-review.googlesource.com/c/1414214
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623159}
[modify] https://crrev.com/9548726e0ee796ac2b5ec56bba2226aab7cff5f1/third_party/blink/renderer/core/css/parser/css_selector_parser.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c317ab643531e1bfff4d58007310cb9faba0cf

commit 58c317ab643531e1bfff4d58007310cb9faba0cf
Author: Fergal Daly <fergal@chromium.org>
Date: Wed Jan 16 11:32:36 2019

[CSS] Support ::part with ::before/::after

This enables it for ::before, ::after and ::placeholder and adds a
test for all 3 but for reasons I haven't dug into yet, ::placeholder
doesn't work with ::part, so this includes a failing expectation.

Bug:  921908 
Change-Id: I60a859ede98f8284cb3a1e44c81a33230b490239
Reviewed-on: https://chromium-review.googlesource.com/c/1414536
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623198}
[modify] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[add] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding-expected.txt
[add] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding.html

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c317ab643531e1bfff4d58007310cb9faba0cf

commit 58c317ab643531e1bfff4d58007310cb9faba0cf
Author: Fergal Daly <fergal@chromium.org>
Date: Wed Jan 16 11:32:36 2019

[CSS] Support ::part with ::before/::after

This enables it for ::before, ::after and ::placeholder and adds a
test for all 3 but for reasons I haven't dug into yet, ::placeholder
doesn't work with ::part, so this includes a failing expectation.

Bug:  921908 
Change-Id: I60a859ede98f8284cb3a1e44c81a33230b490239
Reviewed-on: https://chromium-review.googlesource.com/c/1414536
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623198}
[modify] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[add] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding-expected.txt
[add] https://crrev.com/58c317ab643531e1bfff4d58007310cb9faba0cf/third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding.html

Comment 5 by fergal@chromium.org, Jan 16 (6 days ago)

Test for ::placeholder was added in this but it is failing. ::after and ::before are working now though, so closing.

Comment 6 by fergal@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment