New issue
Advanced search Search tips

Issue 921904 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Calling createOffer twice generates different mids.

Reported by mmalava...@twilio.com, Jan 15

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce the problem:
1. Run https://jsfiddle.net/rnywtqL9/ in a new tab.
2. Open the browser console

What is the expected behavior?
mids in the two offers should be the same

What went wrong?
mids in the two offers are different

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 73.0.3671.3  Channel: canary
OS Version: OS X 10.13.6
Flash Version: 

I was able to reproduce this in Firefox 64. Is this spec compliant behavior?
 
Labels: Needs-Triage-M73

Comment 2 by guidou@chromium.org, Jan 16 (6 days ago)

Components: -Blink>WebRTC Blink>WebRTC>PeerConnection
Owner: hbos@chromium.org
hbos@: Can you take a look or triage further?

Comment 3 by guidou@chromium.org, Jan 16 (6 days ago)

Status: Assigned (was: Unconfirmed)

Comment 4 by hbos@chromium.org, Jan 16 (6 days ago)

Cc: hta@chromium.org
Is this even a bug? You need to setLocalDescription() for the mids to be assigned. Is there anything in the spec that says that generating two offers without setting them must produce the same result for mids?

Comment 5 by mmalava...@twilio.com, Jan 16 (6 days ago)

hbos@: Chrome 72 produces the same mids in multiple calls to createOffer(), but Chrome 73 produces different mids. I was wondering if I could get some insight about whether this change was implemented because it is specified in the spec somewhere?

Comment 6 by hbos@chromium.org, Jan 16 (6 days ago)

Cc: hbos@chromium.org
Owner: steveanton@chromium.org
Interesting. Steve did an awesome job patching SDP in 72 and 73. Steve, do you know which change caused this and if it’s intended?

Comment 7 by steveanton@chromium.org, Jan 16 (6 days ago)

Status: WontFix (was: Assigned)
Yes, this behavior was changed by this CL: https://webrtc-review.googlesource.com/c/src/+/116381

As far as I can tell there's no spec that says a=mid have to be stable if setLocalDescription is not called. In fact, this new behavior matches what Firefox has been doing.

Sign in to add a comment