New issue
Advanced search Search tips

Issue 921837 link

Starred by 4 users
Status: Fixed
Owner:
skau@chromium.org
Closed: Jan 16
Cc:
pgangishetty@chromium.org
matthewjoseph@chromium.org
ka...@chromium.org
weifangsun@chromium.org
sontis@chromium.org
pawliczek@chromium.org
luum@chromium.org
skau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

PrintPreview Crashes on Printer Selection

Project Member Reported by skau@chromium.org, Jan 15 
Tested on  M73_11584.0.0 build.
Tested DUT: Daisy

Browser crashing after selecting wifi printer from print dialog.
crash report link:https://crash.corp.google.com/browse?stbtiq=b891b4b31cb27037

To Repro:
1) Open Print Preview
2) Choose a native printer
3) Wait for setup

Expected Behavior:
Print something

Actual behavior:
Browser crashed

Root cause is Value type was not set properly

Bug introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1375722

Fix in flight

Comment 1 by vkuzkokov@chromium.org, Jan 15 

Fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1404064

At a glance this should've been caught by PrintPreviewHandlerTest.GetPrinterCapabilities. I'm trying to understand why it wasn't

Comment 2 by vkuzkokov@chromium.org, Jan 15 

Re #1: PrintPreviewHandlerTest uses TestPrinterHandler.
Is there a bug for missing coverage in:
chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos.cc
chrome/browser/ui/webui/print_preview/local_printer_handler_default.cc
(StartGetPrinters, StartGetCapability, StartPrint)?

Comment 3 by skau@chromium.org, Jan 15

Cc: pgangishetty@chromium.org matthewjoseph@chromium.org skau@chromium.org
 Issue 922082  has been merged into this issue.

Comment 4 by skau@chromium.org, Jan 16

Status: Fixed (was: Started)
I've filed a bug for the chromeos class. https://crbug.com/922286

Comment 5 by ka...@chromium.org, Jan 17 (5 days ago)

Cc: sontis@chromium.org
 Issue 921069  has been merged into this issue.
►

Sign in to add a comment