tommycli@ can you triage this?

This bug was caused by my CL here:
https://chromium.googlesource.com/chromium/src/+/575dc09174cfeff0f04ac4b9b27733b584cfea57

I'll take responsibility for issuing a fix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18afd26a96b41392d254ce23bfeb9940b4049b1

commit c18afd26a96b41392d254ce23bfeb9940b4049b1
Author: Tommy C. Li <tommycli@chromium.org>
Date: Thu Jan 17 00:59:18 2019

Omnibox: Steady State Elisions - Fix some model vs. view logic division

Chrome has a bug where when the user focuses the Omnibox via Ctrl+L or
F6, sometimes the page action icons disappear.

This is because OmniboxEditModel::Unelide currently lacks a necessary
check. This CL adds that check and adds a test to verify that.

It moves some logic that existed in the OmniboxViewViews over to
OmniboxEditModel and de-duplicates some logic.

Bug: 921777
Change-Id: Ifed90d61e5b820eaaf16b41ba62a13eac73b10ff
Reviewed-on: https://chromium-review.googlesource.com/c/1410016
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623482}
[modify] https://crrev.com/c18afd26a96b41392d254ce23bfeb9940b4049b1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/c18afd26a96b41392d254ce23bfeb9940b4049b1/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/c18afd26a96b41392d254ce23bfeb9940b4049b1/components/omnibox/browser/omnibox_edit_model.h
[modify] https://crrev.com/c18afd26a96b41392d254ce23bfeb9940b4049b1/components/omnibox/browser/omnibox_edit_model_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a

commit 8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Jan 18 18:45:51 2019

Omnibox: Code health - Remove select_all parameter from FocusLocationBar

Currently there is a a select_all parameter that we plumb through all
layers of FocusLocationBar or its equivalent.

This CL removes that parameter, and assumes it's always true. In other
words, any time we focus the location bar, we also select-all.

This parameter is pretty much always set to true. The only place where
that parameter is set to false is from renderer-initiated focuses.

Renderer-initiated focuses are used these scenarios:
 1. When the New Tab Page is loaded, in which case the omnibox is empty,
    and selecting all does nothing.
 2. For media OffscreenTab, there is no location bar, but the absent
    location bar is "focused" to prevent the page content from getting
    input focus. See OffscreenTab::ShouldFocusLocationBarByDefault.
 3. For the PresentationReceiverWindowController, there is also no
    location bar. It's also to prevent the page content from getting
    focus. See PresentationReceiverWindowController::
    ShouldFocusLocationBarByDefault.
 4. When a new tab loads with about:blank, this will change the behavior
    to automatically select-all the "about:blank" text when the
    location bar is auto-focused. This is a desirable change.

In all these cases, setting select_all to true would have no negative
effect.

Bug: 921777, 912722
Change-Id: Idefb493b196f89e23928e925ec9fcf015cac02fa
Reviewed-on: https://chromium-review.googlesource.com/c/1418450
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624213}
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/autocomplete/autocomplete_browsertest.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/ash/chrome_new_window_client.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/browser.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/browser.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/location_bar/location_bar.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/search/instant_uitest_base.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/dropdown_bar_host.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/dropdown_bar_host_delegate.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/find_bar_view.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/chrome/test/base/test_browser_window.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/8bb5bf47fcd1ca8158ca67540c2573b507cfcc8a/content/public/browser/web_contents_delegate.h