New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 921765 link

Starred by 1 user
Status: Started
Owner:
juke@chromium.org
Cc:
jochen@chromium.org
liber...@chromium.org
█ halliwell@chromium.org
dalecur...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up suspend and background play options in media player

Project Member Reported by juke@chromium.org, Jan 14 
There's a |suspend| state in the media playback state machine, which is controlled by |WebMediaPlayerImpl|. However, |suspend| state sometimes doesn't work properly on some content embedders like chromecast because resuming a background video from |suspend| is different from resuming it from |paused|. In order to make the media player work in such cases, two major changes are needed:


- Only control |can_auto_suspend| in WebMediaPlayerImpl;
- Add a flag to enable/disable playing background video in runtime.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fba620b0b948b9fd072469ffa37aceb6da1ba700

commit fba620b0b948b9fd072469ffa37aceb6da1ba700
Author: Junbo Ke <juke@chromium.org>
Date: Wed Jan 16 02:54:36 2019

Clean up suspend and background play options in media player

- Only control |can_auto_suspend| in WebMediaPlayerImpl.
- Add a flag to enable/disable playing background video in runtime.

Bug: 921765
Test: Play YT music in background on Estelle.
Change-Id: I2d6d26977534f4d6345087aca2e165070078065f
Reviewed-on: https://chromium-review.googlesource.com/c/1396780
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623072}
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/chromecast/common/mojom/media_playback_options.mojom
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/chromecast/renderer/cast_media_playback_options.cc
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/chromecast/renderer/cast_media_playback_options.h
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/content/public/renderer/render_frame_media_playback_options.h
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/content/renderer/media/media_factory.cc
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/fba620b0b948b9fd072469ffa37aceb6da1ba700/media/blink/webmediaplayer_params.h
►

Sign in to add a comment