Conflicting resource IDs when generating AR module's resources |
|||||||
Issue descriptionWhen building AR module, the resources get assigned IDs that are conflicting with resource IDs found in base module. Attached are 2 files generated by `aapt dump --values resources <file>` from 2 .apk files, base-master_2.apk and ar-master_2.apk. The APK files were obtained by compiling monochrome_public_bundle and running `monochrome_public_bundle build-bundle-apks` and inspecting the contents of generated .apks file. The conflicting IDs can be seen for example here: - from base-master_2.apk: spec resource 0x7f030004 org.chromium.chrome:array/DefaultGeolocationSettingEntries: flags=0x00000000 - from ar-master_2.apk: spec resource 0x7f030004 org.chromium.chrome:string/__arcore_installing: flags=0x00000000
,
Jan 15
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1415757
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/261896c57103de7f96fa642105841345b41cabf6 commit 261896c57103de7f96fa642105841345b41cabf6 Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Jan 18 19:41:55 2019 Add option to provide package_id when compiling DFMs This CL will also assign 0x7e as a package id for AR module. Bug: 921761 Change-Id: I70c1a015712b4fd11d40c89ee7444f1ae8e20921 Reviewed-on: https://chromium-review.googlesource.com/c/1415757 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624241} [modify] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/build/android/gyp/compile_resources.py [modify] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/build/android/gyp/util/resource_utils.py [modify] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/build/config/android/internal_rules.gni [modify] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/build/config/android/rules.gni [modify] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/chrome/android/modules/ar/ar_module_tmpl.gni [add] https://crrev.com/261896c57103de7f96fa642105841345b41cabf6/chrome/android/modules/module_names_to_package_ids.gni
,
Jan 18
(4 days ago)
,
Jan 18
(4 days ago)
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bialpio@chromium.org
, Jan 15