New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 921751 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

single_process_mash_unit_tests and unit_tests failures on linux-chromeos-rel

Project Member Reported by afakhry@chromium.org, Jan 14

Issue description

https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/18622

Failing tests: 

CastInternalMessageUtilDeathTest.CastInternalMessageFromV2MessageString
CastInternalMessageUtilDeathTest.CastInternalMessageFromClientConnectString
CastInternalMessageUtilDeathTest.CastInternalMessageFromAppMessageString

Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1407303
 
Owner: jrw@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393bb70b5725c96f32b7ecacb0405a2c8ac42e83

commit 393bb70b5725c96f32b7ecacb0405a2c8ac42e83
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Mon Jan 14 21:52:54 2019

Revert "[Cast MRP] Media commands, media status, and SET_VOLUME."

This reverts commit 7d627b6289d62504a5f62280c7eeab35f1a08914.

Reason for revert: Causes test failures on linux-chromeos-rel, See  crbug.com/921751  for details.

BUG= 921751 

Original change's description:
> [Cast MRP] Media commands, media status, and SET_VOLUME.
> 
> Re-roll of https://chromium-review.googlesource.com/c/chromium/src/+/1372666
> 
> This patch implements media commands sent from the SDK to the receiver,
> as well as media status messages from the receiver to the SDK.
> 
> This patch also implements the SET_VOLUME message which sets the system
> level volume and not considered part of media commands.
> 
> Bug: 809249
> Change-Id: If6569aa926c9a458f516f8ca9593a331c1916662
> Reviewed-on: https://chromium-review.googlesource.com/c/1372666
> Commit-Queue: John Williams <jrw@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#622254}
> Reviewed-on: https://chromium-review.googlesource.com/c/1407303
> Cr-Commit-Position: refs/heads/master@{#622597}

TBR=mfoltz@chromium.org,takumif@chromium.org,jrw@chromium.org

Change-Id: I21fe1c15fff39f9409fa14ccfe994387bd2da5d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809249
Reviewed-on: https://chromium-review.googlesource.com/c/1409911
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622619}
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/presentation/presentation_media_sinks_observer.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_app_discovery_service.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_app_discovery_service_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_internal_message_util_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/providers/cast/cast_session_tracker_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/test/test_helper.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/browser/media/router/test/test_helper.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_service_base.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/discovery/media_sink_service_base.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_route.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_route.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_source.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/chrome/common/media_router/media_source.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_handler_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_message_util_unittest.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_socket.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/cast_test_util.h
[modify] https://crrev.com/393bb70b5725c96f32b7ecacb0405a2c8ac42e83/components/cast_channel/keep_alive_delegate.cc

Comment 3 by taku...@chromium.org, Jan 18 (4 days ago)

Status: WontFix (was: Assigned)
Closing the bug, given the culprit CL was reverted.

Sign in to add a comment