Find-It incorrect computation for flake score for URLRequestTestHTTP.Redirect308Tests |
|||
Issue descriptionLink: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRQsSBUZsYWtlIjpjaHJvbWl1bUBuZXRfdW5pdHRlc3RzQFVSTFJlcXVlc3RUZXN0SFRUUC5SZWRpcmVjdDMwOFRlc3RzDA The formula claims that there's only 1 occurence of CQ retry with patch flake, and only 1 impacted CL, for a total score of 0 = 0*100 + 1*10 + 0*1 I checked the first two builds and confirmed that they correspond to different CLs. Furthermore, there are instances of CQ false rejection and CQ hidden flake as well.
,
Jan 14
There are 2 issues here: 1. After supporting cq hidden flakes, the data volume becomes much bigger, so it exceeds the app's memory limit when tries to update all flakes' count and score. 2. We don't calculate flake score if there are too few occurrences. I need to add an explanation on the UI.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3a21b3f7ad8d08c40c12b9d3e1378766f7fc95db commit 3a21b3f7ad8d08c40c12b9d3e1378766f7fc95db Author: Chan <chanli@chromium.org> Date: Mon Jan 14 23:41:15 2019 [Findit] add paging when query flakes for updating their counts. After supporting CQ hidden flakes, the data volume has become much larger. We need to add paging when querying flakes for counts update to make sure the data size is not over limit. Bug: 921747 Change-Id: I6d8b0c7ef5b313dc1f9b7066a2fe80b369d6d69b Reviewed-on: https://chromium-review.googlesource.com/c/1410053 Commit-Queue: Chan Li <chanli@chromium.org> Auto-Submit: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#19971} [modify] https://crrev.com/3a21b3f7ad8d08c40c12b9d3e1378766f7fc95db/appengine/findit/services/flake_detection/update_flake_counts_service.py
,
Jan 15
After change of https://chromium-review.googlesource.com/c/infra/infra/+/1412034, flake score calculating should be back to normal. I had another small related UI change in review. After that change is landed, I'll close this bug.
,
Jan 15
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/761f959925348adc78af28d1be90989cd40b6d14 commit 761f959925348adc78af28d1be90989cd40b6d14 Author: Chan <chanli@chromium.org> Date: Wed Jan 16 05:27:15 2019 [Findit] Flake score graph, do not show formula if flake score is 0. Bug: 921747 Change-Id: Ic73c0b20f83ffa119ee8a172bf8fc6b1742eed64 Reviewed-on: https://chromium-review.googlesource.com/c/1412045 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#20016} [modify] https://crrev.com/761f959925348adc78af28d1be90989cd40b6d14/appengine/findit/ui/elements/flake_detection/flake-score-chart.html
,
Jan 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by chanli@chromium.org
, Jan 14