New issue
Advanced search Search tips

Issue 921728 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

LIMITED_MEDIA_LOG(ERROR, ...) doesn't work on Windows

Project Member Reported by xhw...@chromium.org, Jan 14

Issue description

Tried to use LIMITED_MEDIA_LOG(ERROR, ...) on Windows and hit the following errors. I guess it's because ERROR is defined on Windows to be 0, similar to the explanation in [1]:

../../media/filters/ffmpeg_demuxer.cc(442,5):  error: no member named 'MEDIALOG_0' in 'media::MediaLog'; did you mean 'MEDIALOG_INFO'?
    LIMITED_MEDIA_LOG(ERROR, media_log_, num_convert_packet_errors_,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\media/base/media_log.h(240,15):  note: expanded from macro 'LIMITED_MEDIA_LOG'
  LAZY_STREAM(MEDIA_LOG(level, media_log),                                    \
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\media/base/media_log.h(224,24):  note: expanded from macro 'MEDIA_LOG'
  LogHelper((MediaLog::MEDIALOG_##level), (media_log)).stream()
             ~~~~~~~~~~^
<scratch space>(91,1):  note: expanded from here
MEDIALOG_0
^
../..\base/logging.h(429,63):  note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
                                                              ^~~~~~
../..\media/base/media_log.h(52,5):  note: 'MEDIALOG_INFO' declared here
    MEDIALOG_INFO,
    ^
1 error generated.
[2/81] CXX obj/media/blink/blink/webmediaplayer_impl.obj
ninja: build stopped: subcommand failed.

[1] https://cs.chromium.org/chromium/src/base/logging.h?rcl=150804af3f868b575d5d01ac3992af7971b280e0&l=399

 

Sign in to add a comment