New issue
Advanced search Search tips

Issue 921693 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Task

Blocked on:
issue 921342



Sign in to add a comment

Please scale angle_perftests values to be in milliseconds

Project Member Reported by jmadill@google.com, Jan 14

Issue description

In issue 921342 the baseline time unit was changed from nanoseconds to milliseconds. Additionally the scaling factor was inverted so we ended up with times that were in femtoseconds. Could we get the following scaling applied to the angle_perftests data:

1) 

bots: "Win 7 NVIDIA GPU Perf" and "win10-perf"
tests: everything generated by angle_perftests
revisions: 620237-present**
scaling: divide by 10e12

Applies to chromeperf and v2spa dashboards.

**note: last revision must be after the fix in issue 921342

2) 

bots: "Win 7 NVIDIA GPU Perf" and "android-nexus5x-perf"
tests: everything generated by angle_perftests
revisions: 608300-620236
scaling: divide by 10e6

Only applies to chromeperf dashboard.

There are a few "ms" values in these tests that will be incorrectly scaled but I'm fine with that. We can file issues to have those adjusted individually if it comes up. But I don't expect it to be necessary as they are not very frequently used tests.
 
Description: Show this description
Cc: benjhayden@chromium.org
Does the chromeperf dashboard support this? I am not sure what normally gets done to clean up bad data in these cases. +Ben
Cc: simonhatch@chromium.org
Once your bugfix lands and is rolled into chromium/src, please switch the owner of this bug to me, and I (or Simon) will use my admin superpowers in GAE's dev_console to edit the datastore.

Comment 4 by jmad...@chromium.org, Jan 16 (6 days ago)

Owner: benjhayden@chromium.org
Ben or Simon, could you please help scale the falues? The fix went in and the final affected revision for part 1) is r622872. Note that all tests that need to be scaled are "wall_time".

Comment 5 by jmad...@chromium.org, Jan 16 (6 days ago)

Labels: -Type-Bug Type-Task
Also there are some measurements to be scaled on the "android-nexus5x-perf" bot. This affects part 2) only. I filed  issue 922443  because the tests appear to be missing new measurements but that should not affect this task.

Comment 6 by seanmccullough@chromium.org, Jan 16 (6 days ago)

Owner: simonhatch@chromium.org

Comment 7 by jmad...@chromium.org, Jan 17 (5 days ago)

Actually, might want to wait on this for a bit. It seems there's another potential bug not fixed yet in issue 921342.

Sign in to add a comment