New issue
Advanced search Search tips

Issue 921682 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
M73



Sign in to add a comment

Navi: Histogram in module_metrics_proxy.js doesn't match histograms.xml

Project Member Reported by hcarmona@chromium.org, Jan 14

Issue description

https://crrev.com/c/1364229 changed code to use incorrect reporting metric. Correct metric should be FirstRun.NewUserExperience.GoogleAppsInteraction
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd00e18e7c2409efe9fd7f0d424a098cd6bd1576

commit dd00e18e7c2409efe9fd7f0d424a098cd6bd1576
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Jan 15 01:48:05 2019

Navi: Use GoogleAppsInteraction for reporting metrics.

Bug:  921682 
Change-Id: Id700c6561d17af4e6f6dc115fe0d554b1caa6799
Reviewed-on: https://chromium-review.googlesource.com/c/1409842
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622672}
[modify] https://crrev.com/dd00e18e7c2409efe9fd7f0d424a098cd6bd1576/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js

Labels: Merge-Request-72
Verified that this is working as expected on Canary. This fixes a metrics issue for project navi. Entire change is contained behind a flag for project navi. Change is updating a string in JavaScript only.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 15

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-72 Merge-Approved-72
branch:3626
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c04a81b7b4f4289a678017651964633ffad3751

commit 9c04a81b7b4f4289a678017651964633ffad3751
Author: Hector Carmona <hcarmona@chromium.org>
Date: Tue Jan 15 22:00:15 2019

Navi: Use GoogleAppsInteraction for reporting metrics.

Bug:  921682 
Change-Id: Id700c6561d17af4e6f6dc115fe0d554b1caa6799
Reviewed-on: https://chromium-review.googlesource.com/c/1409842
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#622672}(cherry picked from commit dd00e18e7c2409efe9fd7f0d424a098cd6bd1576)
Reviewed-on: https://chromium-review.googlesource.com/c/1413273
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#700}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/9c04a81b7b4f4289a678017651964633ffad3751/chrome/browser/resources/welcome/onboarding_welcome/shared/module_metrics_proxy.js

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9c04a81b7b4f4289a678017651964633ffad3751

Commit: 9c04a81b7b4f4289a678017651964633ffad3751
Author: hcarmona@chromium.org
Commiter: hcarmona@chromium.org
Date: 2019-01-15 22:00:15 +0000 UTC

Navi: Use GoogleAppsInteraction for reporting metrics.

Bug:  921682 
Change-Id: Id700c6561d17af4e6f6dc115fe0d554b1caa6799
Reviewed-on: https://chromium-review.googlesource.com/c/1409842
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#622672}(cherry picked from commit dd00e18e7c2409efe9fd7f0d424a098cd6bd1576)
Reviewed-on: https://chromium-review.googlesource.com/c/1413273
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#700}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Status: Fixed (was: Started)
Should be fixed when we get our next beta build

Sign in to add a comment