This is breaking canary builds.

Tom would you please take a look?  Thanks!

Mike reviewed this CL.  Mike can you help find someone to fix this?  Thanks!

guessing you meant Tom Hughes rather than Tom Hudson

Yes thanks.
The CL is probably https://chromium-review.googlesource.com/1403897.

iiuc, biod was supposed to be actively shipping only on x86 devices which is why arm seccomp wasn't added (yet).

what is gru-release actually used for ?  i thought that was just a ref board for kevin/bob, and since we're shipping those now, why do we still have a gru builder at all ?

#7: gru-pre-cq is listed as mandatory pre-cq-config for chromeos-4.4, and pending changes for chromeos-4.4 now all fail in pre-cq.

that doesn't really answer my question.  afaik, gru isn't a real device we're going to ship, and it's no longer useful now that we have gru-based devices shipping.  which means we should drop it from all configs and move on.

having a board in the pre-cq but not in the cq is a bad idea.  there is no gru-cq config atm.  which means breaking changes like this are allowed to land.

Adding norvez and mqg.

Sorry about the failure.

One options is that I could disable installing the seccomp file on non-amd64 architectures (Looks like this would be ok since biod will not attempt to reference the seccomp file on gru since it doesn't have /dev/cros_fp: http://cs/chromeos_public/src/platform2/biod/init/biod.conf?l=22-26&rcl=43477a9e5b4f51c9962e16990bc03b87bd0d8c81).

Agreed with comment #9, no reason for gru to still be built, let alone block the pre-cq.

In the mean time, what would be a better board for the pre-cq of kernel 4.4? kevin?

if gru doesn't have /dev/cros_fp, then lets stop setting USE=biod in gru's overlay.

kevin or bob should be fine to replace the pre-cq coverage for linux-4.4.

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1409870 is up for review. It replaces gru with kevin for pre-cq coverage.

Tom, can you remove the biod USE flag from gru?

Nicolas: yes, will remove

Tom: sheriff thanks you for the quick response to this.

Review for removing biod USE flag: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1409501

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6da702e55181b14d48213227702de195767c8503

commit 6da702e55181b14d48213227702de195767c8503
Author: Nicolas Norvez <norvez@chromium.org>
Date: Mon Jan 14 22:09:24 2019

Pre-CQ: replace gru with kevin

gru is not part of the CQ and is not shipping, replace it with an
actually supported board (kevin)

BUG= chromium:921654 
TEST=None

Change-Id: Ia619fd7c041e5977d268f1df8bf0b8bda9b2c652
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1409870
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6da702e55181b14d48213227702de195767c8503/COMMIT-QUEUE.ini

I've just chumped the pre-cq config change for kernel 4.4. I think existing CLs may have to be rebased.

This is blocking depthcharge CLs as well, I've uploaded https://chromium-review.googlesource.com/1410068 for that.

But I'm a little confusing why we're removing all the Gru builders instead of just fixing the problem? If Gru isn't supposed to build biod, why not just remove the USE flag or whatever that makes it do so?

we have done that -- the CL is in the CQ.

that said, it's also a fix to stop using gru configs as gru isn't a real board and we have no real testing of it anymore.  i'll spin this bug into dropping support for the board from GE since it's not useful.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/78f967c356b2b09d640ae86d94b36cf09c5cd069

commit 78f967c356b2b09d640ae86d94b36cf09c5cd069
Author: Tom Hughes <tomhughes@chromium.org>
Date: Tue Jan 15 10:54:50 2019

overlay-gru: remove biod from USE flags

BUG= chromium:921654 
TEST=none

Change-Id: Ie0ed8b7bf1a4a89d29f905a84792d043bfc9525a
Reviewed-on: https://chromium-review.googlesource.com/1409501
Commit-Ready: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/78f967c356b2b09d640ae86d94b36cf09c5cd069/overlay-gru/profiles/base/make.defaults

all breakage should be resolved.  i've filed  issue 921654  for dropping the builders so people stop trying to use it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/2709285f3c126e049f2a25645d34b82f358b675e

commit 2709285f3c126e049f2a25645d34b82f358b675e
Author: Julius Werner <jwerner@chromium.org>
Date: Tue Jan 15 19:35:46 2019

COMMIT-QUEUE: Replace Gru Pre-CQ target with Scarlet

Some change in biod seems to have broken Gru builds. A fix is on the
way, but since Gru isn't a "real" board we should probably stop relying
on it anyway. Add Scarlet in its place so that we're still testing at
least one target with SPI-based Cr50.

BRANCH=None
BUG= chromium:921654 
TEST=None

Change-Id: Ibe5de9b3d7f5b599d7cefccfb7b54261fa3089fd
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1410068
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/2709285f3c126e049f2a25645d34b82f358b675e/COMMIT-QUEUE.ini