Implement YUV caching/decoding for VideoImageGenerator |
|||||
Issue descriptionThe VideoImageGenerator class creates a still image from a VideoFrame and converts it to RGB to be rasterized. It has partial support for YUV decoding, so after the GpuImageDecodeCache YUV caching and rendering infrastructure is landed, it makes sense to modify VideoImageGenerator to leverage that. This is the tracking bug for such changes. The path is currently unused for the same reasons JPEG YUV decoding is not hit right now crrev.com/c/1400764 and crbug.com/921101 . Relevant design doc: bit.ly/webp-decoding-into-yuv
,
Jan 14
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
+sunnyps, zmo. As mentioned on the doc GpuMemoryBuffers use a variety of weird formats to upload into, so even draw stage might now always need RGB.
,
Jan 17
(5 days ago)
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/071aec40f0f5c52c358c60ab2296af3724cc5c7a commit 071aec40f0f5c52c358c60ab2296af3724cc5c7a Author: Madeleine Barowsky <mbarowsky@chromium.org> Date: Fri Jan 18 01:50:00 2019 [MEDIA] Disable VideoImageGenerator YUV decodes until pipeline is ready. The VideoImageGenerator YUV decoding path is currently unused, despite its previous usage under Skia-driven decoding. See [1]. This change will ensure that we do not attempt to decode or upload stills of video frames in YUV until the changes for YUV decoding/rendering/caching in CC/Blink have safely landed. See bit.ly/webp-decoding-into-yuv for the design doc of that feature and crrev.com/c/1338461 for a working prototype CL. [1]: https://codereview.chromium.org/1418573002/ Bug: 921636 Change-Id: I1b0a9d5b14832b4d0099199cf13cc459552138e3 Reviewed-on: https://chromium-review.googlesource.com/c/1418322 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#623951} [modify] https://crrev.com/071aec40f0f5c52c358c60ab2296af3724cc5c7a/media/renderers/paint_canvas_video_renderer.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mbarow...@chromium.org
, Jan 14