New issue
Advanced search Search tips

Issue 921615 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate oauth2_token_service_observer_bridge*

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

It's no longer used. lebel@chromium.org should review as well to confirm.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Labels: Pri-1

Comment 3 by ma...@igalia.com, Jan 16 (6 days ago)

Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11b37cd3d41c2e88aa837f9e8b60230fa0d90af2

commit 11b37cd3d41c2e88aa837f9e8b60230fa0d90af2
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Wed Jan 16 12:41:02 2019

Eliminate oauth2_token_service_observer_bridge*

This is no longer used for the iOS build and can be safely removed.

Bug:  921615 
Change-Id: Iccc65ed6ce63f081f0a76d9d3d59786c898cdc7d
Reviewed-on: https://chromium-review.googlesource.com/c/1414891
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623207}
[modify] https://crrev.com/11b37cd3d41c2e88aa837f9e8b60230fa0d90af2/components/signin/ios/browser/BUILD.gn
[delete] https://crrev.com/f425cfd3729d3705682c51f3cd49aa77a5507e83/components/signin/ios/browser/oauth2_token_service_observer_bridge.h
[delete] https://crrev.com/f425cfd3729d3705682c51f3cd49aa77a5507e83/components/signin/ios/browser/oauth2_token_service_observer_bridge.mm

Comment 6 by ma...@igalia.com, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment