New issue
Advanced search Search tips

Issue 921613 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Convert //chromeos/services/assistant/service.cc to use identity::ScopeSet

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

Enables elimination of oauth2_token_service.h include.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Labels: Pri-1

Comment 3 by ma...@igalia.com, Jan 16 (6 days ago)

Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aacb4fc1f524ade63567c41f4cf4515df22971c8

commit aacb4fc1f524ade63567c41f4cf4515df22971c8
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Jan 18 10:07:26 2019

Convert //chromeos/services/assistant/service.cc to use identity::ScopeSet

This allows removing a dependency on oauth2_token_service.h.

Bug:  921613 
Change-Id: I0470d54b30af8c481784dd37902a8485bf8c2b52
Reviewed-on: https://chromium-review.googlesource.com/c/1412030
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624054}
[modify] https://crrev.com/aacb4fc1f524ade63567c41f4cf4515df22971c8/chromeos/services/assistant/service.cc

Comment 6 by ma...@igalia.com, Jan 18 (4 days ago)

Status: Fixed (was: Started)

Sign in to add a comment