New issue
Advanced search Search tips

Issue 921612 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate signin_error_notifier_factory_ash.cc's include of profile_oauth2_token_service.h

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

Looks stale.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Owner: gyuyo...@igalia.com
I'd like to take over this bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2536c3002ddfb7d229585dda40dc1fe427469aa2

commit 2536c3002ddfb7d229585dda40dc1fe427469aa2
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Tue Jan 15 14:50:24 2019

s13n: Eliminate signin_error_notifier_factory_ash.cc's include of profile_oauth2_token_service.h

There is no use of ProfileOAuth2TokenService in signin_error_notifier_factory_ash.cc.
We don't need to keep the include of profile_oauth2_token_service.h.

Bug:  921612 
Change-Id: Id8c857cc36e6e8c342f1ee559d91eb26f7d7d219
Reviewed-on: https://chromium-review.googlesource.com/c/1410833
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622852}
[modify] https://crrev.com/2536c3002ddfb7d229585dda40dc1fe427469aa2/chrome/browser/signin/signin_error_notifier_factory_ash.cc

Labels: Pri-1

Comment 5 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Available)

Sign in to add a comment