New issue
Advanced search Search tips

Issue 921611 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate search_suggest_service_unittest.cc's |signin_client_| and |token_service_| ivars and their corresponding includes

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

These look unused.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Labels: Pri-1

Comment 3 by abhij...@igalia.com, Jan 16 (6 days ago)

Owner: abhij...@igalia.com

Comment 4 by abhij...@igalia.com, Jan 16 (6 days ago)

Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8eadaf186f4cec0649428a2c49d6e037040ad91

commit a8eadaf186f4cec0649428a2c49d6e037040ad91
Author: Abhijeet Kandalkar <abhijeet@igalia.com>
Date: Wed Jan 16 17:59:27 2019

Remove unused variables and headers

Removed |signin_client_| and |token_service_| ivars and their
corresponding includes from search_suggest_service_unittest.cc

Bug:  921611 
Change-Id: I5e3645b6d12fdd2eac4097dc25132d743563b131
Reviewed-on: https://chromium-review.googlesource.com/c/1414740
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623288}
[modify] https://crrev.com/a8eadaf186f4cec0649428a2c49d6e037040ad91/chrome/browser/search/search_suggest/search_suggest_service_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/066fa57d3f86fc223544ea565a6d6e7eeb0da4ff

commit 066fa57d3f86fc223544ea565a6d6e7eeb0da4ff
Author: Abhijeet Kandalkar <abhijeet@igalia.com>
Date: Sat Jan 19 08:06:23 2019

Remove ScopedTaskEnvironment references from search_suggest_service_unittest.cc

This is follow up implementation for CL1414740. Removed call to
RunUntilIdle as SetCookieAccounts internally run loop

Bug:  921611 
Change-Id: I5431c9b1665f6aa84a0beb3be7ea88c012e21d7c
Reviewed-on: https://chromium-review.googlesource.com/c/1417432
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624458}
[modify] https://crrev.com/066fa57d3f86fc223544ea565a6d6e7eeb0da4ff/chrome/browser/search/search_suggest/search_suggest_service_unittest.cc

Comment 7 by abhij...@igalia.com, Jan 20 (2 days ago)

Status: Fixed (was: Started)

Sign in to add a comment