New issue
Advanced search Search tips

Issue 921610 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate one_google_bar_unittest.cc's |signin_client_| and |token_service_| ivars and their corresponding includes

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

These look unused.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Labels: Pri-1

Comment 3 by abhij...@igalia.com, Jan 16 (6 days ago)

Owner: abhij...@igalia.com

Comment 4 by abhij...@igalia.com, Jan 16 (6 days ago)

Cc: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d887b622db98e41cfacb4daf12e27dc87ae7e52

commit 9d887b622db98e41cfacb4daf12e27dc87ae7e52
Author: Abhijeet Kandalkar <abhijeet@igalia.com>
Date: Fri Jan 18 14:27:34 2019

Remove PrefService, AccountTrackerService and ScopedTaskEnvironment references from one_google_bar_service_unittest.cc

Removed |signin_client_| and |token_service_| ivars and their
corresponding includes from one_google_bar_service_unittest.cc

Removed unwated calls to |task_environment_|

Bug:  921610 
Change-Id: I429652a10d5b89f92a1472cf655cc63c07721c8f
Reviewed-on: https://chromium-review.googlesource.com/c/1415230
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#624111}
[modify] https://crrev.com/9d887b622db98e41cfacb4daf12e27dc87ae7e52/chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc

Comment 6 by abhij...@igalia.com, Jan 20 (2 days ago)

Status: Fixed (was: Started)

Sign in to add a comment