New issue
Advanced search Search tips

Issue 921605 link

Starred by 2 users
Status: Started
Owner:
abhij...@igalia.com
Cc:
abhij...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate references to TokenService in identity_apitest.cc

Project Member Reported by blundell@chromium.org, Jan 14 
There are a couple stray references to "TokenService" in identity_apitest.cc (in a comment and a test name). Let's move those intelligently to refer to IdentityManager.

Comment 1 by blundell@chromium.org, Jan 14

Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)

Comment 2 by blundell@chromium.org, Jan 15

Labels: Pri-1

Comment 3 by abhij...@igalia.com, Jan 16 (6 days ago)

Owner: abhij...@igalia.com

Comment 4 by abhij...@igalia.com, Jan 19 (3 days ago)

Owner: ----
I found some headers that could be removed.

The CL is here https://crrev.com/c/1424057.

Is there anything missing to be updated apart from this, Colin?

If someone interested in taking it further, please feel free to take it.

Comment 5 by blundell@chromium.org, Yesterday (37 hours ago) 

Hi, thanks!

Yes, just changing the textual references to "TokenService" to instead be to "IdentityManager". You can find them by grepping for "TokenService" in the file.

Comment 6 by abhij...@igalia.com, Today (20 hours ago)

Cc: abhij...@igalia.com
Owner: abhij...@igalia.com
Status: Started (was: Available)
►

Sign in to add a comment