New issue
Advanced search Search tips

Issue 921604 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Remove stale oauth2_token_service.h include from identity_api.h

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

Looks unused, and will help to clarify the exact usage of OAuth2TokenService.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Owner: gyuyo...@igalia.com
I'd like to take over this bug.
Labels: Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b503fbe90573b59267dc1a6730be67efa09086f

commit 0b503fbe90573b59267dc1a6730be67efa09086f
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Wed Jan 16 02:10:43 2019

s13n: Remove unnecessary oauth2_token_service.h|oquth2_mint_token_flow.h include from identity_api.h

indentity_api.h doesn't use anything related to OAuth2. So this CL removes unnecessary
includes of oauth2_foo.h files in identity_api.h.

Bug:  921604 
Change-Id: I3330ad8cfcf434f49aba792fef2616bf8895184e
Reviewed-on: https://chromium-review.googlesource.com/c/1410852
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623035}
[modify] https://crrev.com/0b503fbe90573b59267dc1a6730be67efa09086f/chrome/browser/extensions/api/identity/identity_api.h

Comment 5 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Available)

Sign in to add a comment