New issue
Advanced search Search tips

Issue 921603 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Remove stale oauth2_token_service.h include from device_command_screenshot_job.h

Project Member Reported by blundell@chromium.org, Jan 14

Issue description

Looks unused, and helps to clarify the users of oauth2_token_service.h.
 
Blocking: 883318
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug
Status: Available (was: Untriaged)
Owner: gyuyo...@igalia.com
I'd like to take over this bug.
Labels: Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27e751fa1c169d7775f4ca7365c54965f32d17f4

commit 27e751fa1c169d7775f4ca7365c54965f32d17f4
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Wed Jan 16 02:05:48 2019

s13n: Remove stale oauth2_token_service.h include from device_command_screenshot_job.h

There is no use of OAuth2TokenService in DeviceCommandScreenshotJob. So we don't need
to keep the oauth2_token_service.h include in device_command_screenshot_job.h anymore.

Bug:  921603 
Change-Id: If759299cdb296ab6b7ab20b15b87f051a865d74e
Reviewed-on: https://chromium-review.googlesource.com/c/1411352
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623027}
[modify] https://crrev.com/27e751fa1c169d7775f4ca7365c54965f32d17f4/chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

Comment 5 by gyuyo...@igalia.com, Jan 17 (6 days ago)

Status: Fixed (was: Available)

Sign in to add a comment