New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 921582 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

sequence-point warnings from gcc8 compilation

Project Member Reported by tomas.ch...@gmail.com, Jan 14

Issue description

Chrome Version: 72.0.3626.53
OS: openSUSE

With gcc compilation it of course report many warnings that are not relevant but on 3 places it seems something wrong is happening in the code:

One occurance is in webrtc module:
[ 1047s] ../../third_party/webrtc/modules/audio_processing/aec3/reverb_decay_estimator.cc: In member function 'void webrtc::ReverbDecayEstimator::LateReverbLinearRegressor::Reset(int)':
[ 1047s] ../../third_party/webrtc/modules/audio_processing/aec3/reverb_decay_estimator.cc:290:10: warning: operation on '((webrtc::ReverbDecayEstimator::LateReverbLinearRegressor*)this)->webrtc::ReverbDecayEstimator::LateReverbLinearRegressor::count_' may be undefined [-Wsequence-point]
[ 1047s]    count_ = N > 0 ? count_ = -N * 0.5f + 0.5f : 0.f;
[ 1047s]    ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


And twice in the chrome proper:

[ 5042s] In file included from gen/chrome/browser/browser_jumbo_91.cc:9:
[ 5042s] ./../../chrome/browser/download/download_shelf_controller.cc: In member function 'void DownloadShelfController::OnNewOfflineItemReady(DownloadUIModel::DownloadUIModelPtr)':
[ 5042s] ./../../chrome/browser/download/download_shelf_controller.cc:68:30: warning: operation on 'browser' may be undefined [-Wsequence-point]
[ 5042s]    Browser* browser = browser = chrome::FindLastActiveWithProfile(profile_);
[ 5042s]                       ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ 6720s] In file included from gen/headless/headless_jumbo_2.cc:10:
[ 6720s] ./../../headless/lib/browser/protocol/browser_handler.cc: In member function 'virtual headless::protocol::Response headless::protocol::BrowserHandler::SetWindowBounds(int, std::unique_ptr<headless::prot
ocol::Browser::Bounds>)':
[ 6720s] ./../../headless/lib/browser/protocol/browser_handler.cc:81:56: warning: operation on 'web_contents' may be undefined [-Wsequence-point]
[ 6720s]    HeadlessWebContentsImpl* web_contents = web_contents =
[ 6720s]                                            ~~~~~~~~~~~~~^
[ 6720s]        browser()->GetWebContentsForWindowId(window_id);
[ 6720s]        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   


Those lines seem also to be present in the HEAD on the git repo but I am not able to compile -dev variant most of the time and as such can only verify stuff on -beta version.
 
.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c795a8739203edce37f71466aa3b9ae12eb8440

commit 5c795a8739203edce37f71466aa3b9ae12eb8440
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jan 16 17:30:13 2019

Fix errors generated from gcc8

Double assignment occurred for these variables. Remove it.

BUG= 921582 

Change-Id: I47d65ad493ee9bb01a7307b500c0e028fed9233f
Reviewed-on: https://chromium-review.googlesource.com/c/1409605
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623274}
[modify] https://crrev.com/5c795a8739203edce37f71466aa3b9ae12eb8440/chrome/browser/download/download_shelf_controller.cc
[modify] https://crrev.com/5c795a8739203edce37f71466aa3b9ae12eb8440/headless/lib/browser/protocol/browser_handler.cc

Comment 4 by dtapu...@chromium.org, Jan 16 (6 days ago)

Components: Blink>WebRTC
Only remaining issue is webrtc issue which is in another repository. Over to WebRTC to triage.

Comment 5 by guidou@chromium.org, Jan 17 (5 days ago)

Cc: mbonadei@chromium.org jansson@chromium.org
Components: -Blink>WebRTC Internals>WebRTC

Comment 6 by guidou@chromium.org, Jan 17 (5 days ago)

Owner: peah@chromium.org
Status: Assigned (was: Untriaged)
peah@: Can you fix the offending line in reverb_decay_estimator.cc or reassign?

Comment 7 by peah@chromium.org, Jan 17 (5 days ago)

Absolutely! I'll contact the author of the code.
Project Member

Comment 8 by bugdroid1@chromium.org, Yesterday (38 hours ago)

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e6a4793b16ca961da660257bb6cf3350d08fef96

commit e6a4793b16ca961da660257bb6cf3350d08fef96
Author: Jesús de Vicente Peña <devicentepena@webrtc.org>
Date: Mon Jan 21 15:38:21 2019

AEC3: avoiding a warning in the reverberation decay estimator.

In this CL a warning is avoided in the reverberation decay estimator code. The change is bitexact.

Bug:  chromium:921582 
Change-Id: I5a91f4b5970a21ba6da7254cf7fad8c2d0bcac4b
Reviewed-on: https://webrtc-review.googlesource.com/c/118441
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26342}
[modify] https://crrev.com/e6a4793b16ca961da660257bb6cf3350d08fef96/modules/audio_processing/aec3/reverb_decay_estimator.cc

Comment 9 by peah@chromium.org, Yesterday (36 hours ago)

With the CL in #8, the issue can be closed.

Comment 10 by peah@chromium.org, Yesterday (36 hours ago)

Status: Fixed (was: Assigned)

Comment 11 by peah@chromium.org, Yesterday (36 hours ago)

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows OS-iOS
Project Member

Comment 12 by bugdroid1@chromium.org, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699

commit 94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 22 14:07:59 2019

Roll src/third_party/webrtc 74ba99062c48..71b5a7df7794 (53 commits)

https://webrtc.googlesource.com/src.git/+log/74ba99062c48..71b5a7df7794


git log 74ba99062c48..71b5a7df7794 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 srte@webrtc.org Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
2019-01-21 srte@webrtc.org Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
2019-01-21 hofbauer@webrtc.org Clarify and unify network delay plot annotations.
2019-01-21 hofbauer@webrtc.org Add Visual Studio Code project folder to gitignore file.
2019-01-21 artit@webrtc.org Remove dimensions subarray from internal iOS bots config
2019-01-21 sprang@webrtc.org Move congestion window field trial parsing to new class.
2019-01-21 danilchap@webrtc.org Connect global task queue factory and rtc::TaskQueue
2019-01-21 magjed@webrtc.org Android: Add option to print native stack traces in PeerConnectionFactory API
2019-01-21 orphis@webrtc.org Remove simulcast constraints in SimulcastEncoderAdapter
2019-01-21 devicentepena@webrtc.org AEC3: avoiding a warning in the reverberation decay estimator.
2019-01-21 magjed@webrtc.org Reland "Android: Add helper methods for printing native stack traces"
2019-01-21 eladalon@webrtc.org Deprecate FirstSubFrameInFrame() and LastSubFrameInFrame()
2019-01-21 srte@webrtc.org Removes clock from TransportFeedbackAdapter.
2019-01-21 nisse@webrtc.org Reland "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."
2019-01-21 nisse@webrtc.org Reland "Trim down FileWrapper class to be merely a wrapper owning a FILE*"
2019-01-21 magjed@webrtc.org Revert "Android: Add helper methods for printing native stack traces"
2019-01-21 artit@webrtc.org Change webrtc-internal iOS pool for try and ci bots
2019-01-21 qingsi@google.com Replace the usage of RTC_HISTOGRAM_COMMON_BLOCK with
2019-01-21 hta@webrtc.org Add 2 new virtual methods to IceTransportInternal
2019-01-21 nisse@webrtc.org Revert "Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2."
2019-01-21 nisse@webrtc.org Refactor WebRtcVideoEngine tests to not use cricket::VideoCapturer, part 2.
2019-01-21 nisse@webrtc.org Refactor VideoTrackTest to not depend on cricket::VideoCapturer
2019-01-20 magjed@webrtc.org Android: Remove static thread references from PeerconnectionFactory
2019-01-20 magjed@webrtc.org Android: Add helper methods for printing native stack traces
2019-01-18 crodbro@webrtc.org Fix for bandwidth toggling problem in StartUpPhase.
2019-01-18 terelius@webrtc.org Add some missing includes and dependencies.
2019-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f804d91f5..1cac36a781 (624000:624101)
2019-01-18 minyue@webrtc.org Adding text log on actual opus bitrate.
2019-01-18 nisse@webrtc.org Refactor PeerConnectionInterfaceTest to not depend on cricket::VideoCapturer
2019-01-18 ilnik@webrtc.org Update jitter delay on per-superframe level from FrameBuffer
2019-01-18 nisse@webrtc.org Add test WebRtcVideoChannelTest.DoesNotAdaptWhenScreeensharing
2019-01-18 nisse@webrtc.org Refactor PeerConnectionFactoryTest to not use FakeVideoCapturer.
2019-01-18 sprang@webrtc.org Don't include packetization overhead in protection bitrate.
2019-01-18 nisse@webrtc.org Revert "Trim down FileWrapper class to be merely a wrapper owning a FILE*"
2019-01-18 danilchap@webrtc.org Update PlatformThread constructor to take name with absl::string_view
2019-01-18 ilnik@webrtc.org Set inter_pic_predicted video codec flag in vp9 encoder correctly
2019-01-18 danilchap@webrtc.org Introduce global task queue factory.
2019-01-18 artit@webrtc.org Increase even more timeout for internal iOS perf
2019-01-18 srte@webrtc.org Adds repeating task class.
2019-01-18 srte@webrtc.org Adds WebRtcKeyValueConfig interface
2019-01-18 nisse@webrtc.org Trim down FileWrapper class to be merely a wrapper owning a FILE*
2019-01-18 zstein@webrtc.org Remove unused friend declaration from ParsedRtcEventLog.
2019-01-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 16c3dfe1d0..2f804d91f5 (623888:624000)
2019-01-18 amithi@webrtc.org Fixing possible bug when Flex and RTX used together.
2019-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e291b99915..16c3dfe1d0 (623778:623888)
2019-01-17 amithi@webrtc.org Revert "Opus multistream."
2019-01-17 titovartem@webrtc.org Introduce VideoFrameWriter.
2019-01-17 mbonadei@webrtc.org Revert "AEC3: Lockless transfer of render data to the capture thread"
2019-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a9216d2da..e291b99915 (623639:623778)
2019-01-17 Peter) Slatala DTLS transport needs to forward network route change.
2019-01-17 titovartem@webrtc.org Introduce ExampleVideoQualityAnalyzer.
2019-01-17 sprang@webrtc.org Add ability for VideoEncoder to signal frame rate allocation.
2019-01-17 sprang@webrtc.org Move some video codec constants to separate file.


Created with:
  gclient setdep -r src/third_party/webrtc@71b5a7df7794

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:none,chromium:921582,chromium:921023,chromium:864871,chromium:None,chromium:None,chromium:912122,chromium:None,chromium:922396,chromium:NONE,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6321648925f5a9781be3b886626342a08b25a9e9
Reviewed-on: https://chromium-review.googlesource.com/c/1425970
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624768}
[modify] https://crrev.com/94cbf3f56197bcd83ba7a9830dcfcd0e1fcf2699/DEPS

Sign in to add a comment