New issue
Advanced search Search tips

Issue 921546 link

Starred by 1 user
Status: Fixed
Owner:
mstensho@chromium.org
Closed: Jan 14
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Footer area is displayed at the top in print preview page.

Project Member Reported by sav...@virtusa.com, Jan 14 
Chrome Version : 73.0.3671.0 (Official Build) d2dfa7d40588461802e7e6dca7d86b583060eda9-refs/branch-heads/3671@{#1} (32/64 Bit)

OS : Mac(10.13.1, 10.13.6, 10.14.3) ,Win (7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and Navigate to https://www.google.com
2. Give print command using ‘command+p’.
3. Under more settings, Select paper size to 'A4’ and increase the ‘scale’ greater than ‘110’

Actual Result   : Footer area is displayed at the top in print preview page.
Expected Result : Footer should be at its original position at the bottom of print preview.

This is a regression issue broken in M-73 and below is the bisect information:
Good Build : 73.0.3636.0 (Revision : 615029)
Bad Build  : 73.0.3637.0 (Revision : 615356)

CHANGE-LOG URL :
https://chromium.googlesource.com/chromium/src/+log/1281aa2b06be40e78271c1815e98d645e6a16a74..2d503464aba5fec00db42711485377f4262dcde7?pretty=fuller&n=10000

Suspect: r615089 ?

@mstensho: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Issue is also reproducible on Dev Build #73.0.3664.3 
2. Unable to perform bisect using per-revision script as it was giving trace-back error.
3. Hence providing suspect with Chromium Bisect.

Kindly refer attached screen cast.

Thank You!
Actual_result.mov
4.1 MB View Download
Expected_result.mov
3.9 MB View Download

Comment 1 by mstensho@chromium.org, Jan 14

Components: Blink>Layout
Thank you. Confirming that r615089 is the one causing this.

Comment 2 by nyerramilli@google.com, Jan 14

Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required

Comment 3 by mstensho@chromium.org, Jan 14

tc.html
341 bytes View Download

Comment 4 by mstensho@chromium.org, Jan 14 

Minimal non-interactive testcase (using multicol instead of printing) attached.
tc2.html
588 bytes View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9815df2e17e7cc61e622a402ec4c7af6d1367c2

commit c9815df2e17e7cc61e622a402ec4c7af6d1367c2
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Jan 14 17:26:28 2019

Mark top estimate for bottom-aligned OOFs as bogus when fragmented.

As the code already points out, the block-start estimate for block-end
aligned out-of-flow positioned objects cannot be determined without
laying out. Make sure that we really lay out.

Bug:  921546 
Change-Id: Id49b7b846886070ce3e49e0220a7b6378e1f9d6a
Reviewed-on: https://chromium-review.googlesource.com/c/1409442
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622492}
[modify] https://crrev.com/c9815df2e17e7cc61e622a402ec4c7af6d1367c2/third_party/blink/renderer/core/layout/layout_block.cc
[add] https://crrev.com/c9815df2e17e7cc61e622a402ec4c7af6d1367c2/third_party/blink/web_tests/external/wpt/css/css-break/block-end-aligned-abspos-nested.html

Comment 6 by e...@chromium.org, Jan 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment