New issue
Advanced search Search tips

Issue 921543 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Progress bar does not meet scrubber dot when width is modified to '800'.

Project Member Reported by aim...@virtusa.com, Jan 14

Issue description

Chrome Version: 73.0.3671.0 (Official Build) d2dfa7d40588461802e7e6dca7d86b583060eda9-refs/branch-heads/3671@{#1} (32/64 Bit).

OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.3), Linux(14.04 LTS).

Test URL: https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html

What steps will reproduce the problem?
1. Launch chrome and Navigate to the above URL and select 'Audio' from options.
2. Now, drag video progress bar to the fullest.
3. Change width to '800' and observe progress bar.

Actual Result: Progress bar does not meet scrubber dot when width is modified to '800'.
Expected Result: Progress bar should meet scrubber dot when modifying width to '800'

This is a regression issue broken in M-72 and below is the bisect info:
Good Build : 72.0.3596.0(Revision : 603701)
Bad Build : 72.0.3597.0(Revision : 604362)

You are probably looking for a change made after 604173 (known good), but no later than 604174 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bb76e2f3f708e095a81e5b777f3ab3034cf66678..e70b5b06140f678b56203ec2eb271b7b027f3667

Suspect: https://chromium.googlesource.com/chromium/src/+/e70b5b06140f678b56203ec2eb271b7b027f3667

jazzhsu@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is also seen on Beta #	72.0.3626.53 and Dev #73.0.3664.3 build.

Kindly refer the screen cast for reference

Thank You!
 
Actual Result.mp4
511 KB View Download
Expected Result.mp4
333 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a490cf0b183ac614a056c044d8eafc105b786b38

commit a490cf0b183ac614a056c044d8eafc105b786b38
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Wed Jan 16 23:06:26 2019

[Media Controls] Fix progress not meeting scrubber when change size

Force the timeline element render itself when size change.

Bug:  921543 
Change-Id: I1e35275170457855362b3529085adaf3a956f6a4
Reviewed-on: https://chromium-review.googlesource.com/c/1409729
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623428}
[modify] https://crrev.com/a490cf0b183ac614a056c044d8eafc105b786b38/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[add] https://crrev.com/a490cf0b183ac614a056c044d8eafc105b786b38/third_party/blink/web_tests/media/controls/progress-bar-repaint-on-size-change.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a490cf0b183ac614a056c044d8eafc105b786b38

commit a490cf0b183ac614a056c044d8eafc105b786b38
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Wed Jan 16 23:06:26 2019

[Media Controls] Fix progress not meeting scrubber when change size

Force the timeline element render itself when size change.

Bug:  921543 
Change-Id: I1e35275170457855362b3529085adaf3a956f6a4
Reviewed-on: https://chromium-review.googlesource.com/c/1409729
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623428}
[modify] https://crrev.com/a490cf0b183ac614a056c044d8eafc105b786b38/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[add] https://crrev.com/a490cf0b183ac614a056c044d8eafc105b786b38/third_party/blink/web_tests/media/controls/progress-bar-repaint-on-size-change.html

Comment 3 by jazzhsu@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment