New issue
Advanced search Search tips

Issue 921542 link

Starred by 1 user
Status: Fixed
Owner:
battre@chromium.org
Closed: Jan 14
Cc:
frechette@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

ScopedListUpdate and ScopedDictionaryUpdate fail with non-empty default dictionaries

Project Member Reported by battre@chromium.org, Jan 14 
If a PrefService has a registered preference whose default value is a non-empty dictionary or list, then the Scoped*Update functions fail to clone those dictionaries.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/904348e9fd097685b80273f1149c17035533eac4

commit 904348e9fd097685b80273f1149c17035533eac4
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jan 14 15:48:13 2019

Fix Scoped{List,Dictionary}Updates for non-empty defaut values

If a PrefService has a registered preference whose default value is a non-empty
dictionary or list, then the Scoped*Update functions failed to clone those
dictionaries. This is fixed by this CL.

Bug:  921542 
Change-Id: Ifad622d6345dd6797fa97ac6c2f917eb3928cb98
Reviewed-on: https://chromium-review.googlesource.com/c/1408969
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622465}
[modify] https://crrev.com/904348e9fd097685b80273f1149c17035533eac4/components/prefs/pref_service.cc
[modify] https://crrev.com/904348e9fd097685b80273f1149c17035533eac4/components/prefs/scoped_user_pref_update_unittest.cc

Comment 2 by battre@chromium.org, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment