New issue
Advanced search Search tips

Issue 921523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: DumpAccessibilityTreeTest.AccessibilityOffscreenScroll



Sign in to add a comment

DumpAccessibilityTreeTest.AccessibilityOffscreenScroll is flaky

Project Member Reported by Findit, Jan 14

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/167723

================================================================================

[ RUN      ] DumpAccessibilityTreeTest.AccessibilityOffscreenScroll

DevTools listening on ws://127.0.0.1:56773/devtools/browser/7e5ac77c-ab80-48fe-a55e-aa1d1d10fb78
[5176:4316:0114/013821.259:INFO:media_foundation_video_encode_accelerator_win.cc(347)] Windows versions earlier than 8 are not supported.
[5940:6104:0114/013821.421:INFO:dump_accessibility_browsertest_base.cc(245)] Testing: e:/b/s/w/ir/content/test/data/accessibility/html/offscreen-scroll.html
[5940:6104:0114/013821.421:INFO:dump_accessibility_browsertest_base.cc(247)] Expected output: e:/b/s/w/ir/content/test/data/accessibility/html/offscreen-scroll-expected-blink.txt
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc(379): error: Value of: is_different
  Actual: true
Expected: false
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x00EC58E8+40]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00ECCC97+69]
	testing::internal::AssertHelper::operator= [0x00ECC902+48]
	content::DumpAccessibilityTestBase::RunTestForPlatform [0x001362CC+3484]
	content::DumpAccessibilityTestBase::RunTest [0x001354EC+58]
	content::DumpAccessibilityTreeTest::RunHtmlTest [0x0013F81F+175]
	content::DumpAccessibilityTreeTest_AccessibilityOffscreenScroll_Test::RunTestOnMainThread [0x0015191D+13]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x027A57B4+436]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x03183BC3+67]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x01211DB3+51]
	content::StartupTaskRunner::RunAllTasksNow [0x0159D5C8+30]
	content::BrowserMainLoop::CreateStartupTasks [0x01210C6C+804]
	content::BrowserMainRunnerImpl::Initialize [0x01213F28+88]
	ShellBrowserMain [0x055DA15F+43]
	content::ShellMainDelegate::RunProcess [0x055D8BEE+158]
	content::RunBrowserProcessMain [0x01135219+65]
	content::ContentMainRunnerImpl::RunServiceManager [0x01135C22+670]
	content::ContentMainRunnerImpl::Run [0x0113595F+351]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x01134E63+19]
	service_manager::Main [0x02D76ECE+882]
	content::ContentMain [0x0113517F+51]

[5940:6104:0114/013821.717:ERROR:dump_accessibility_browsertest_base.cc(404)] Diff:
* Line Expected
- ---- --------
     1 rootWebArea scrollY=100
     2 ++button offscreen name='Onscreen before scroll'
*    3 ++button name='Scrolled Button'
     4 <-- End-of-file -->
     5 <-- End-of-file -->

Actual
------
rootWebArea scrollY=100
++button offscreen name='Onscreen before scroll'
++button offscreen name='Scrolled Button'
<-- End-of-file -->
[5940:6104:0114/013821.730:INFO:dump_accessibility_browsertest_base.cc(230)] File not found: e:\b\s\w\ir\content\test\data\accessibility\html\offscreen-scroll-expected-win.txt
[5940:6104:0114/013821.730:INFO:dump_accessibility_browsertest_base.cc(231)] No expectation file present, ignoring test on this platform. To run this test anyway, create e:\b\s\w\ir\content\test\data\accessibility\html\offscreen-scroll-expected-win.txt (it can be empty) and then run content_browsertests with the switch: --generate-accessibility-test-expectations
[5940:3952:0114/013821.757:WARNING:discardable_shared_memory_manager.cc(410)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[  FAILED  ] DumpAccessibilityTreeTest.AccessibilityOffscreenScroll, where TypeParam =  and GetParam() =  (617 ms)
Owner: katydek@google.com
Status: Assigned (was: Untriaged)
Screenshot_20190114_133511.png
248 KB View Download
Owner: katie@chromium.org
Labels: -Sheriff-Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/1409189 is in CQ, owner assigned. --> Moving out of sheriff queue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95de362e85f94212d46f68f57bfab78d471bf613

commit 95de362e85f94212d46f68f57bfab78d471bf613
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jan 14 13:14:07 2019

Disable flaky DumpAccessibilityTreeTest.AccessibilityOffscreen on Win

TBR=katie@chromium.org

Bug:  921523 
Change-Id: If48f4f2dab9b3d37a865bf9f7406c6cf3ff6ab5b
Reviewed-on: https://chromium-review.googlesource.com/c/1409189
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622437}
[modify] https://crrev.com/95de362e85f94212d46f68f57bfab78d471bf613/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9715ef0d14ddb9306ba3dd378ffee589d3973ab

commit a9715ef0d14ddb9306ba3dd378ffee589d3973ab
Author: Katie D <katie@chromium.org>
Date: Wed Jan 16 01:31:35 2019

Fix and re-enable DumpAccessibilityTreeTest.AccessibilityOffscreenScroll.

Adds padding below the element so that we ensure a scroll happens
even if the window is too small or too large.

Bug:  921523 
Change-Id: I13d857d3180eebfe28cf6e28ea83b6df72fb5f52
Reviewed-on: https://chromium-review.googlesource.com/c/1410082
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622980}
[modify] https://crrev.com/a9715ef0d14ddb9306ba3dd378ffee589d3973ab/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/a9715ef0d14ddb9306ba3dd378ffee589d3973ab/content/test/data/accessibility/html/offscreen-scroll-expected-blink.txt
[modify] https://crrev.com/a9715ef0d14ddb9306ba3dd378ffee589d3973ab/content/test/data/accessibility/html/offscreen-scroll.html

Comment 10 by katie@chromium.org, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment