New issue
Advanced search Search tips

Issue 921501 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 859882



Sign in to add a comment

Port signin_ui_util.cc away from GaiaCookieManagerService::ListAccounts

Project Member Reported by lowell@google.com, Jan 14

Issue description

It should be ported to use IdentityManager::GetAccountsInCookieJar, instead of GaiaCookieManagerService::ListAccounts

See the 'Migration Guide' for specifics, including example CL:
https://docs.google.com/document/d/1bO7JsZE-xA8DSE18NeCZffbAnFZTo6vAtBCKsxaz4u8/edit#heading=h.y21mzvk0pm4c

 
Blocking: 859882
Components: Internals>Services>Identity
Labels: Proj-Servicification Proj-Servicification-VendorBug Pri-1
Status: Available (was: Untriaged)
Owner: hferre...@igalia.com
Status: Started (was: Available)
Labels: Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc26cfa47ea4d893086e9839ce07297a54fc422

commit 6bc26cfa47ea4d893086e9839ce07297a54fc422
Author: Henrique Ferreiro <hferreiro@igalia.com>
Date: Wed Jan 16 10:58:06 2019

Port signin_ui_util.cc away from ListAccounts()

The CL removes the dependency on GaiaCookieManagerService

Bug:  921501 
Change-Id: I948d868c437d99399050192f6efd4667cf0e12ac
Reviewed-on: https://chromium-review.googlesource.com/c/1411922
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623191}
[modify] https://crrev.com/6bc26cfa47ea4d893086e9839ce07297a54fc422/chrome/browser/signin/signin_ui_util.cc

Comment 6 by hferre...@igalia.com, Jan 16 (6 days ago)

Status: Fixed (was: Started)

Sign in to add a comment