New issue
Advanced search Search tips

Issue 921467 link

Starred by 1 user
Status: Fixed
Owner:
timvolod...@chromium.org
Closed: Jan 14
Cc:
battre@google.com
mvanouwe...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

chrome_public_test_apk failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 14 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of battre@google.com

chrome_public_test_apk failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI

Comment 1 by battre@chromium.org, Jan 14

Labels: -Pri-2 Pri-1
Owner: timvolod...@chromium.org
Status: Assigned (was: Available)
org.chromium.chrome.browser.customtabs.dynamicmodule.CustomTabsDynamicModuleLoaderTest#testModuleUseCounter
org.chromium.chrome.browser.customtabs.dynamicmodule.CustomTabsDynamicModuleLoaderTest#testModuleLoading

First failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/4234

There are two suspicious CLs.

Tim, can you take a look at this? I'll focus on sheriffing the desktop platforms.

Comment 2 by timvolod...@chromium.org, Jan 14

Labels: OS-Android
The two suspicious CLs:
- https://chromium-review.googlesource.com/c/1405189 (Register cct module lifecycle)
- https://chromium-review.googlesource.com/c/1406686 (increase cct module api version)
investigating further

Comment 3 by timvolod...@chromium.org, Jan 14

Cc: mvanouwe...@chromium.org
ok it appears to be the first one:
- https://chromium-review.googlesource.com/c/1405189 (Register cct module lifecycle)

(reverting locally makes the test pass)

+mvanouwerkerk@ as author of the patch

Comment 4 by timvolod...@chromium.org, Jan 14 

talked to mvanouwerkerk@ and I am going to revert this.

(it's not exactly clear at this point why the tests are failing, they are crashing segfaulting but without much info in the logcat at this point)

Comment 6 by timvolod...@chromium.org, Jan 14

Status: Fixed (was: Assigned)

Comment 7 by mvanouwe...@chromium.org, Jan 15 

Issue 922036 has been merged into this issue.
►

Sign in to add a comment